fix(ci): ignore resolved Codex inline findings#1002
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12c8e080ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,23 @@ | |||
| ## MODIFIED Requirements | |||
There was a problem hiding this comment.
Declare the new OpenSpec requirement as added
This delta is under MODIFIED Requirements, but openspec/specs/github-automation/spec.md does not contain an existing requirement named Codex review label sync review-thread state; it currently only defines the write-token fallback and write-denial resilience requirements. OpenSpec treats MODIFIED as changes to an existing requirement, so strict validation/archive will fail for this change instead of accepting the new review-thread-state contract. Since this is a new requirement, move it under ADDED Requirements or add the matching base requirement first.
Useful? React with 👍 / 👎.
|
Folded this into #981 ( |
Summary
Ignore resolved or outdated inline Codex review findings when syncing
🤖 codexlabels, so a PR can becomecodex: okafter the finding thread has actually been handled.Type of change
fix:— bug fix (no behavior change beyond the bug)feat:— new user-facing feature or capabilityrefactor:— internal refactor (no behavior change, no API change)docs:— documentation onlychore:/ci:/build:— tooling, CI, packagingtest:— test-only change!after the type, e.g.feat!:or includeBREAKING CHANGE:footer)Linked issue: Related to #703
OpenSpec
shape, SSE framing, OAuth flow) and preserves upstream-equivalent behavior
Change directory:
openspec/changes/ignore-resolved-codex-inline-findings/Changes
Test plan
Screenshots / output (optional)
Patched dry-run against #703 before applying labels:
Checklist
<type>(<scope>)?: <subject>).uv run pre-commit run local-ci --hook-stage manual --all-filesor the relevantmake <target>subset locally.openspec validate --specspasses and/opsx:verifyis clean.