-
Notifications
You must be signed in to change notification settings - Fork 36
feat: templated external links (draft) #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
GBirkel
wants to merge
24
commits into
SciCatProject:master
from
als-computing:templated-external-links-v2
Closed
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
92bde05
Adding 'external link' Class to old and current "output dataset" API.
GBirkel 806533d
Merge branch 'SciCatProject:master' into templated-external-links-v2
GBirkel 1baa254
Test version of virtual (derived) value for external links.
GBirkel ddeceeb
Applying some test templates, in a draft data structure
GBirkel 1cd8986
Adding a config json file and section for link templates.
GBirkel 58e1b48
Moving the virtual field creation up to the module so we can get acce…
GBirkel a419d1d
Minor commentary and cleanup.
GBirkel e0a77ca
Merge branch 'refs/heads/master' into templated-external-links-v2
GBirkel fa3d6f3
Too much nesting. :D
GBirkel d1d1544
Lint.
GBirkel 9afc970
Sorry linter, we actually need this for the anonymous filter/map func…
GBirkel 42fee6a
Mentioning datasetExternalLinkTemplates.json in the development instr…
GBirkel 023bfd7
Just a bit of code cleanup.
GBirkel 9183bcf
Adding v3 and v4 endpoints for /:pid/externallinks , calling a common…
GBirkel ce6e498
Removing the injected virtual field code for dataset links.
GBirkel ea96c52
The list of external links is no longer returned as a field in the da…
GBirkel b04c6fa
Merge branch 'refs/heads/master' into templated-external-links-v2
GBirkel c570748
This is no longer true. :D
GBirkel b76cce2
OutputAttachmentV3Dto is not a schema (it has no Mongo representation…
GBirkel 0e8304e
Merge branch 'refs/heads/master' into templated-external-links-v2
GBirkel bf27ced
Merge branch 'refs/heads/master' into templated-external-links-v2
GBirkel c650365
Lint
GBirkel 12d5e25
Upgrading dependency to latest release to test SDK generation
GBirkel 846ff80
Removing imports that are no longer used.
GBirkel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { ApiProperty } from "@nestjs/swagger"; | ||
| import { IsString } from "class-validator"; | ||
|
|
||
| // This data is not represented in Mongoose. | ||
| // It is generated internally based on the user-defined link templates. | ||
|
|
||
| export class ExternalLinkClass { | ||
| @ApiProperty({ | ||
| type: String, | ||
| required: true, | ||
| description: "URL of the external link.", | ||
| }) | ||
| @IsString() | ||
| readonly url: string; | ||
|
|
||
| @ApiProperty({ | ||
| type: String, | ||
| required: true, | ||
| description: "Text to display representing the external link.", | ||
| }) | ||
| @IsString() | ||
| readonly title: string; | ||
|
|
||
| @ApiProperty({ | ||
| type: String, | ||
| required: false, | ||
| description: "Description of the link destination.", | ||
| }) | ||
| @IsString() | ||
| readonly description?: string; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.