feat: templated external links (draft)#2097
Closed
GBirkel wants to merge 24 commits into
Closed
Conversation
5 tasks
nitrosx
requested changes
Aug 8, 2025
nitrosx
left a comment
nitrosx
left a comment
Member
There was a problem hiding this comment.
IT can be approved after fixing the linting and adding some API testing.
Also I would check if dataset schema to obsolete dto works correctly
Contributor
Author
It does, though I had to add Looks like the current-to-obsolete conversion is the only code that uses |
…ss to the injected configuration.
… function in the Dataset service.
…). Referencing it as one in the APIs causes a validation failure, which prevents the SDK from compiling. I assume this is a new error caused by some package upgrade that made validation more precise.
Member
|
Duplication PR with https://github.com/SciCatProject/backend/pull/2194/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a field for generating dataset links based on admin-configured templates.
See #689 for details.
This has a companion PR for the front end: SciCatProject/frontend#1910 .
Motivation
We get a lot of requests from users and researchers to provide a variety of different types of web-based tools that related directly to datasets. These can be pages that display visualization, pages that provide analysis tools (including AI/ML) and jupyter notebooks on particular JupyterHub instance. In all cases, we would want to take the user to the page with the dataset in context.
Fixes
Changes:
Tests included
Documentation
official documentation info