Skip to content

build(pytorch) [Release 7.14] Remove pytorch 2.9 + nightly #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HereThereBeDragons merged 1 commit into from
Jul 6, 2026
+2 −13
Merged

build(pytorch) [Release 7.14] Remove pytorch 2.9 + nightly #6291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions build_tools/github_actions/configure_pytorch_release_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,8 @@
# pytorch_git_ref – git branch/tag passed to the build job
# exclude_amdgpu_families – (optional) set[str] of family names to drop

# adjusted for release/therock-7.14
PYTORCH_REFS_LINUX: list[dict] = [
{
"pytorch_git_ref": "release/2.9",
# gfx125x not supported for PyTorch 2.9.
"exclude_amdgpu_families": {"gfx125x"},
},
Comment on lines -31 to -35

@ScottTodd ScottTodd Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're dropping support for the pytorch release/2.9 branch, shouldn't we also do that on TheRock's main branch for nightly releases too? Why just for TheRock's release/7.14 branch?

@HereThereBeDragons HereThereBeDragons Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should. i havent heard any resistant against it since i proposed this to lockstep this with the release.

{
"pytorch_git_ref": "release/2.10",
# gfx125x not supported for PyTorch 2.10.
Expand All @@ -49,21 +45,14 @@
# See https://github.com/ROCm/TheRock/issues/5833.
"exclude_amdgpu_families": {"gfx125x"},
},
{

@ScottTodd ScottTodd Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the more recent code on the main branch we could choose to drop nightly if the release_type is prerelease, see

TheRock/build_tools/github_actions/configure_pytorch_release_matrix.py

Lines 29 to 51 in a13cf65

# TODO: separate out "nightly" pytorch refs from "prerelease" pytorch refs?
# That would let us:
# 1. choose to not build the "nightly" pytorch branch for prerelease builds,
# saving some CI resources and possibly simplifying package promotion
# scripts.
# 2. filter out some AMDGPU families from prereleases if we only want them
# built for nightly but not published to stable.
RELEASE_PYTORCH_REFS = {
"linux": [
"release/2.9",
"release/2.10",
"release/2.11",
"release/2.12",
"nightly",
],
"windows": [
"release/2.9",
"release/2.10",
"release/2.11",
"release/2.12",
"nightly",
],
}

@HereThereBeDragons HereThereBeDragons Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that would be a good change on main.

"pytorch_git_ref": "nightly",
# gfx125x not yet upstreamed to pytorch/pytorch.
# See https://github.com/ROCm/TheRock/issues/5833.
"exclude_amdgpu_families": {"gfx125x"},
},
]

# adjusted for release/therock-7.14
# gfx125x is Linux-only; no exclusion needed for Windows.
PYTORCH_REFS_WINDOWS: list[dict] = [
{"pytorch_git_ref": "release/2.9"},
{"pytorch_git_ref": "release/2.10"},
{"pytorch_git_ref": "release/2.11"},
{"pytorch_git_ref": "release/2.12"},
{"pytorch_git_ref": "nightly"},
]


Expand Down
Loading