build(pytorch) [Release 7.14] Remove pytorch 2.9 + nightly#6291
Conversation
ScottTodd
left a comment
There was a problem hiding this comment.
Do we actually need this? I'd prefer to keep changes on the release branches minimal. Without this change we'll build more packages than we publish and I think our package promotion scripts already handle that?
| # See https://github.com/ROCm/TheRock/issues/5833. | ||
| "exclude_amdgpu_families": {"gfx125x"}, | ||
| }, | ||
| { |
There was a problem hiding this comment.
With the more recent code on the main branch we could choose to drop nightly if the release_type is prerelease, see
There was a problem hiding this comment.
agree that would be a good change on main.
| { | ||
| "pytorch_git_ref": "release/2.9", | ||
| # gfx125x not supported for PyTorch 2.9. | ||
| "exclude_amdgpu_families": {"gfx125x"}, | ||
| }, |
There was a problem hiding this comment.
If we're dropping support for the pytorch release/2.9 branch, shouldn't we also do that on TheRock's main branch for nightly releases too? Why just for TheRock's release/7.14 branch?
There was a problem hiding this comment.
yes we should. i havent heard any resistant against it since i proposed this to lockstep this with the release.
i would argue the less people need to think about what we are triggering in the release, the better. if we manage to have this more automated and dont need so many changes on the release branch thats of course preferred but currently we are not there yet. for the download script yes you can have include and exclude globs, for promotion just include glob. one more thought: |
ScottTodd
left a comment
There was a problem hiding this comment.
Do we actually need this? I'd prefer to keep changes on the release branches minimal. Without this change we'll build more packages than we publish and I think our package promotion scripts already handle that?
i would argue the less people need to think about what we are triggering in the release, the better. if we manage to have this more automated and dont need so many changes on the release branch thats of course preferred but currently we are not there yet.
Agreed. Alright, I'm fine with this change then.
5d3b1b7
into
release/therock-7.14
Adjust pytorch build matrix matching 7.14 release matrix.
Drops building pytorch 2.9 and nightly