Skip to content

build(pytorch) [Release 7.14] Remove pytorch 2.9 + nightly#6291

Merged
HereThereBeDragons merged 1 commit into
release/therock-7.14from
users/lpromber/7.14_adjust_pytorch_matrix
Jul 6, 2026
Merged

build(pytorch) [Release 7.14] Remove pytorch 2.9 + nightly#6291
HereThereBeDragons merged 1 commit into
release/therock-7.14from
users/lpromber/7.14_adjust_pytorch_matrix

Conversation

@HereThereBeDragons

@HereThereBeDragons HereThereBeDragons commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Adjust pytorch build matrix matching 7.14 release matrix.
Drops building pytorch 2.9 and nightly

@HereThereBeDragons HereThereBeDragons requested review from a team and ScottTodd July 1, 2026 09:21
@HereThereBeDragons HereThereBeDragons marked this pull request as draft July 1, 2026 09:22
@HereThereBeDragons HereThereBeDragons marked this pull request as ready for review July 1, 2026 09:27

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need this? I'd prefer to keep changes on the release branches minimal. Without this change we'll build more packages than we publish and I think our package promotion scripts already handle that?

# See https://github.com/ROCm/TheRock/issues/5833.
"exclude_amdgpu_families": {"gfx125x"},
},
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the more recent code on the main branch we could choose to drop nightly if the release_type is prerelease, see

# TODO: separate out "nightly" pytorch refs from "prerelease" pytorch refs?
# That would let us:
# 1. choose to not build the "nightly" pytorch branch for prerelease builds,
# saving some CI resources and possibly simplifying package promotion
# scripts.
# 2. filter out some AMDGPU families from prereleases if we only want them
# built for nightly but not published to stable.
RELEASE_PYTORCH_REFS = {
"linux": [
"release/2.9",
"release/2.10",
"release/2.11",
"release/2.12",
"nightly",
],
"windows": [
"release/2.9",
"release/2.10",
"release/2.11",
"release/2.12",
"nightly",
],
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that would be a good change on main.

Comment on lines -31 to -35
{
"pytorch_git_ref": "release/2.9",
# gfx125x not supported for PyTorch 2.9.
"exclude_amdgpu_families": {"gfx125x"},
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're dropping support for the pytorch release/2.9 branch, shouldn't we also do that on TheRock's main branch for nightly releases too? Why just for TheRock's release/7.14 branch?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should. i havent heard any resistant against it since i proposed this to lockstep this with the release.

@HereThereBeDragons

HereThereBeDragons commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Do we actually need this? I'd prefer to keep changes on the release branches minimal. Without this change we'll build more packages than we publish and I think our package promotion scripts already handle that?

i would argue the less people need to think about what we are triggering in the release, the better. if we manage to have this more automated and dont need so many changes on the release branch thats of course preferred but currently we are not there yet.

for the download script yes you can have include and exclude globs, for promotion just include glob.
however also for accountability in the future and reducing confusion i think it would be better to just build what we want and not build everything and then select.

one more thought:
maybe in the future we immediately drop the old versions we no longer want to support on main before the branch cut and then just have the exception "if release skip nightly"

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need this? I'd prefer to keep changes on the release branches minimal. Without this change we'll build more packages than we publish and I think our package promotion scripts already handle that?

i would argue the less people need to think about what we are triggering in the release, the better. if we manage to have this more automated and dont need so many changes on the release branch thats of course preferred but currently we are not there yet.

Agreed. Alright, I'm fine with this change then.

@HereThereBeDragons HereThereBeDragons merged commit 5d3b1b7 into release/therock-7.14 Jul 6, 2026
134 of 142 checks passed
@HereThereBeDragons HereThereBeDragons deleted the users/lpromber/7.14_adjust_pytorch_matrix branch July 6, 2026 16:35
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants