Skip to content

ci: re-enable Windows unit tests #7419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Claude wants to merge 7 commits into
base: master
Choose a base branch
from
+17 −18
Draft

ci: re-enable Windows unit tests #7419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e49575
Initial plan
Claude Mar 20, 2026
b147eb0
Re-enable Windows CI unit tests with memory optimizations
Claude Mar 20, 2026
e47c9a2
Change parallel compilation flag from /MP2 to /MP
DennisOSRM Mar 22, 2026
ee0494d
Merge branch 'master' into claude/enable-windows-ci-unit-tests
DennisOSRM Apr 28, 2026
0063173
Merge branch 'master' into claude/enable-windows-ci-unit-tests
DennisOSRM Apr 30, 2026
338ce60
ci: increase heap space in msvc
DennisOSRM Apr 30, 2026
7b16373
Update OSRM backend workflow to remove CXXFLAGS
DennisOSRM May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions .github/workflows/osrm-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
continue-on-error: false
env:
BUILD_TYPE: Release
CXXFLAGS: "/Zm256 /MP2"
steps:
- uses: actions/checkout@v6
- run: cmake --version
Expand Down Expand Up @@ -70,25 +71,22 @@ jobs:
run: |
cmake --preset ci-windows -DENABLE_NODE_BINDINGS=ON
cmake --build --preset ci-windows
- name: Run tests
shell: bash
run: |
cd build
cmake --build . --config Release --target tests
- name: Run node tests
shell: bash
run: |
./lib/binding_napi_v8/osrm-extract.exe -p profiles/car.lua test/data/monaco.osm.pbf

mkdir -p test/data/ch
cp test/data/monaco.osrm* test/data/ch/
./lib/binding_napi_v8/osrm-contract.exe test/data/ch/monaco.osrm

# TODO: MSVC goes out of memory when building our tests
# - name: Run tests
# shell: bash
# run: |
# cd build
# cmake --build . --config Release --target tests
# # TODO: run tests
# - name: Run node tests
# shell: bash
# run: |
# ./lib/binding_napi_v8/osrm-extract.exe -p profiles/car.lua test/data/monaco.osm.pbf

# mkdir -p test/data/ch
# cp test/data/monaco.osrm* test/data/ch/
# ./lib/binding_napi_v8/osrm-contract.exe test/data/ch/monaco.osrm

# ./lib/binding_napi_v8/osrm-datastore.exe test/data/ch/monaco.osrm
# node test/nodejs/index.js
./lib/binding_napi_v8/osrm-datastore.exe test/data/ch/monaco.osrm
node test/nodejs/index.js
- name: Build Node package
shell: bash
run: ./scripts/ci/node_package.sh
Expand Down
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj") # avoid compiler error C1128 from scripting_environment_lua.cpp
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /DWIN32_LEAN_AND_MEAN") # avoid compiler error C2011 from dual #include of winsock.h and winsock2.h
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /utf-8") # support Unicode in fmt library
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP") # limit parallel compilation to reduce memory usage
add_dependency_defines(-DBOOST_LIB_DIAGNOSTIC)
add_dependency_defines(-D_CRT_SECURE_NO_WARNINGS)
add_dependency_defines(-DNOMINMAX) # avoid min and max macros that can break compilation
Expand Down
Loading