Skip to content

Swap sign of flux divergence #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btobers wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Swap sign of flux divergence #1815

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8ac2d8
Swap sign of flux divergence
btobers Nov 11, 2025
610d684
Added to whats-new.rst
btobers Nov 11, 2025
4c8558f
Update comment above flux divergence calculation
pat-schmitt Apr 28, 2026
f4beaa8
Refactor flux divergence calculation in test
pat-schmitt May 26, 2026
835cee6
trigger test workflow
pat-schmitt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ v1.6.x (not released)

Enhancements
~~~~~~~~~~~~

- Resolved inverted sign of flowline diagnostics flux divergence (:pull:`1815`).
By `Brandon Tober <https://github.com/btobers>`_
- Added ``tasks.compute_fl_diagnostics_quantiles``, this task is designed to
calculate quantiles from multiple fl_diagnostic files. It enables users to
compute metrics such as the median flowline across various GCM projections
Expand Down
2 changes: 1 addition & 1 deletion oggm/core/flowline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,7 @@ def run_until_and_store(self, y1,
surface_h_previous[fl_id] = fl.surface_h
if 'flux_divergence' in ovars_fl and (yr > self.y0):
# calculated after the formula dhdt = mb + flux_div

@pat-schmitt pat-schmitt Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to '# calculated after the formula mb = dhdt + flux_div'

val = ds['dhdt'].data[i, :] - ds['climatic_mb'].data[i, :]
val = ds['climatic_mb'].data[i, :] - ds['dhdt'].data[i, :]
# special treatment for retreating: If the glacier
# terminus is getting ice free it means the
# climatic mass balance is more negative than the
Expand Down
Loading