Swap sign of flux divergence#1815
Open
btobers wants to merge 5 commits into
Open
Conversation
Member
|
Thanks @btobers ! Much appreciated. Given the nature of the change I'll hold off merging right now and will wait for the after the next minor release (very soon) |
Member
|
@pat-schmitt are you fine with this? We will have to adapt the tests and the documentation / tutorials as well. |
pat-schmitt
reviewed
Apr 28, 2026
| @@ -1347,7 +1347,7 @@ def run_until_and_store(self, y1, | |||
| surface_h_previous[fl_id] = fl.surface_h | |||
| if 'flux_divergence' in ovars_fl and (yr > self.y0): | |||
| # calculated after the formula dhdt = mb + flux_div | |||
Member
There was a problem hiding this comment.
change this to '# calculated after the formula mb = dhdt + flux_div'
Member
|
Thanks @btobers for spotting this. I used the wrong equation. I just added a comment to also change the comment above the new calculation. I can have a look at the tests the next weeks. |
Member
|
I just changed the comment to run the tests again |
Member
|
Beside of changing documentation and tutorials this is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1814
This PR addresses an issue with the sign of the flux divergence stored within the flowline diagnostics.
whats-new.rst