Skip to content

demos: standalone system-services-monitor demo#1383

Draft
dmvevents wants to merge 1 commit into
NVIDIA:mainfrom
dmvevents:demo-system-services-monitor
Draft

demos: standalone system-services-monitor demo#1383
dmvevents wants to merge 1 commit into
NVIDIA:mainfrom
dmvevents:demo-system-services-monitor

Conversation

@dmvevents

Copy link
Copy Markdown

Per #891 split (5 of 5). Marked draft — depends on PR landing first.

Series progress

What this contains

  • demos/system-services-monitor/ standalone demo subtree

What this does NOT contain

  • Implementation (impl PR)
  • Helm chart (PR 4)

CR-ignored findings addressed

  • daemonset.yaml image pin to SHA
  • livenessProbe httpGet check
  • servicemonitor.yaml alert spec
  • Dockerfile python:3.13 (CVE)

cc @XRFXLP

Lands the demo subtree (NVIDIA#891 split, 5 of 5). Standalone — depends on
the implementation in <impl-pr-num> but doesn't gate any production
functionality.

Includes CR-ignored fixes from the umbrella PR:
- daemonset.yaml: image pinned to SHA tag (not :0.1.0)
- daemonset.yaml: livenessProbe httpGet validated
- servicemonitor.yaml: FabricManagerFlapping alert spec
- Dockerfile: python:3.13 base for CVE remediation
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 00c3d3ee-03a1-402d-b4f5-feac6001f5f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

@dmvevents this PR has been inactive for 14 days. Do you need help finishing it, or should we close it for now? Feel free to reopen anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant