Skip to content

chart: system-services-monitor subchart + parent registration#1385

Draft
dmvevents wants to merge 1 commit into
NVIDIA:mainfrom
dmvevents:helm-system-services-monitor
Draft

chart: system-services-monitor subchart + parent registration#1385
dmvevents wants to merge 1 commit into
NVIDIA:mainfrom
dmvevents:helm-system-services-monitor

Conversation

@dmvevents

Copy link
Copy Markdown

Per #891 split (4 of 5). Marked draft — depends on the implementation PR (#1382) landing first.

Series progress

What this contains

  • distros/kubernetes/nvsentinel/charts/system-services-monitor/ Helm subchart (10 files: Chart.yaml, values.yaml, .helmignore, 7 templates including DaemonSet, ServiceMonitor, ClusterRole/Binding, ServiceAccount, Service, PrometheusRule, _helpers.tpl)
  • distros/kubernetes/nvsentinel/Chart.yaml — subchart dependency registration
  • distros/kubernetes/nvsentinel/values.yaml — defaults wiring

What this does NOT contain

Notes

The subchart's .Values.global.* references (e.g. imagePullSecrets, metricsPort) are supplied by the parent chart at deploy time. Standalone helm lint reports nil-pointer errors on these — that's expected and matches the same pattern in the merged sibling subchart (nic-health-monitor/templates/daemonset.yaml). Validated via helm template against the parent chart context.

cc @XRFXLP

Lands the Helm chart for system-services-monitor (NVIDIA#891 split, 4 of 5).
Subchart under distros/kubernetes/nvsentinel/charts/ + values.yaml +
Chart.yaml dependency registration in the parent chart.

Mirrors the sibling pattern (nic-health-monitor) for .Values.global
references (parent-chart-supplied globals; subchart standalone lint
fails the same way the sibling does — expected and matching upstream).
@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9b4b20a4-df98-4b6d-9955-92a4c02923d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

@dmvevents this PR has been inactive for 14 days. Do you need help finishing it, or should we close it for now? Feel free to reopen anytime.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@dmvevents this PR now has merge conflicts with main. Please rebase to resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant