chart: system-services-monitor subchart + parent registration#1385
chart: system-services-monitor subchart + parent registration#1385dmvevents wants to merge 1 commit into
Conversation
Lands the Helm chart for system-services-monitor (NVIDIA#891 split, 4 of 5). Subchart under distros/kubernetes/nvsentinel/charts/ + values.yaml + Chart.yaml dependency registration in the parent chart. Mirrors the sibling pattern (nic-health-monitor) for .Values.global references (parent-chart-supplied globals; subchart standalone lint fails the same way the sibling does — expected and matching upstream).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@dmvevents this PR has been inactive for 14 days. Do you need help finishing it, or should we close it for now? Feel free to reopen anytime. |
|
@dmvevents this PR now has merge conflicts with |
Per #891 split (4 of 5). Marked draft — depends on the implementation PR (#1382) landing first.
Series progress
What this contains
distros/kubernetes/nvsentinel/charts/system-services-monitor/Helm subchart (10 files: Chart.yaml, values.yaml, .helmignore, 7 templates including DaemonSet, ServiceMonitor, ClusterRole/Binding, ServiceAccount, Service, PrometheusRule, _helpers.tpl)distros/kubernetes/nvsentinel/Chart.yaml— subchart dependency registrationdistros/kubernetes/nvsentinel/values.yaml— defaults wiringWhat this does NOT contain
Notes
The subchart's
.Values.global.*references (e.g.imagePullSecrets,metricsPort) are supplied by the parent chart at deploy time. Standalonehelm lintreports nil-pointer errors on these — that's expected and matches the same pattern in the merged sibling subchart (nic-health-monitor/templates/daemonset.yaml). Validated viahelm templateagainst the parent chart context.cc @XRFXLP