-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ci: add workflow to validate Ondo Tokenized metadata has a label #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vivek-consensys
wants to merge
3
commits into
master
Choose a base branch
from
feat/validate-ondo-labels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| name: Validate Ondo Tokenized Labels | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| validate-ondo-labels: | ||
| name: Validate Ondo Tokenized Labels | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Get changed metadata files in this PR | ||
| id: changed | ||
| run: | | ||
| # List files added or modified in this PR vs the base branch | ||
| git diff --name-only --diff-filter=AM origin/${{ github.base_ref }}...HEAD \ | ||
| | grep '^metadata/.*\.json$' > changed_metadata.txt || true | ||
| echo "Changed metadata files:" | ||
| cat changed_metadata.txt || echo "(none)" | ||
|
|
||
| - name: Check Ondo Tokenized metadata has a label file | ||
| run: | | ||
| set -euo pipefail | ||
|
|
||
| ERRORS=() | ||
|
|
||
| while IFS= read -r file; do | ||
| [ -f "$file" ] || continue | ||
|
|
||
| if python3 -c "import json,sys; d=json.load(open('$file')); sys.exit(0 if '(Ondo Tokenized)' in d.get('name','') else 1)" 2>/dev/null; then | ||
| # Derive expected label path: | ||
| # metadata/eip155:1/erc20:0xABC.json -> labels/eip155:1/erc20:0xABC.json | ||
| label_file="${file/metadata\//labels/}" | ||
|
|
||
| if [ ! -f "$label_file" ]; then | ||
| ERRORS+=("Missing label file for: $file (expected: $label_file)") | ||
| else | ||
| # Confirm labels array is non-empty | ||
| if ! python3 -c " | ||
| import json, sys | ||
| with open('$label_file') as f: | ||
| data = json.load(f) | ||
| if not data.get('labels'): | ||
| sys.exit(1) | ||
| " 2>/dev/null; then | ||
| ERRORS+=("Label file exists but has no labels: $label_file") | ||
| fi | ||
| fi | ||
| fi | ||
| done < changed_metadata.txt | ||
|
|
||
| if [ ${#ERRORS[@]} -gt 0 ]; then | ||
| echo "" | ||
| echo "❌ Validation failed — the following Ondo Tokenized metadata entries are missing a label file:" | ||
| echo "" | ||
| for err in "${ERRORS[@]}"; do | ||
| echo " • $err" | ||
| done | ||
| echo "" | ||
| echo "Every token whose name contains '(Ondo Tokenized)' must have a corresponding" | ||
| echo "label file under labels/ with at least one label (e.g. \"ondo\")." | ||
| echo "" | ||
| echo "To add a label, run:" | ||
| echo " npm run asset:set -- --caip <caip> --labels \"ondo\"" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "✅ All Ondo Tokenized metadata entries in this PR have a valid label file." | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git diff failure skips validation
Medium Severity
The changed-metadata step pipes
git diffintogrepand ends with|| truewithoutpipefail. Ifgit difffails (for example whenorigin/${{ github.base_ref }}is missing or invalid), the step still succeeds,changed_metadata.txtstays empty, and the label check passes without validating any files.Reviewed by Cursor Bugbot for commit 25db382. Configure here.