ci: add workflow to validate Ondo Tokenized metadata has a label#1844
Open
vivek-consensys wants to merge 3 commits into
Open
ci: add workflow to validate Ondo Tokenized metadata has a label#1844vivek-consensys wants to merge 3 commits into
vivek-consensys wants to merge 3 commits into
Conversation
5cafbf0 to
d6aaa45
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 25db382. Configure here.
| run: | | ||
| # List files added or modified in this PR vs the base branch | ||
| git diff --name-only --diff-filter=AM origin/${{ github.base_ref }}...HEAD \ | ||
| | grep '^metadata/.*\.json$' > changed_metadata.txt || true |
There was a problem hiding this comment.
Git diff failure skips validation
Medium Severity
The changed-metadata step pipes git diff into grep and ends with || true without pipefail. If git diff fails (for example when origin/${{ github.base_ref }} is missing or invalid), the step still succeeds, changed_metadata.txt stays empty, and the label check passes without validating any files.
Reviewed by Cursor Bugbot for commit 25db382. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds a GitHub Actions workflow that validates any PR adding or modifying metadata for Ondo Tokenized tokens includes a corresponding label file.
Motivation
As Ondo Global Markets tokenized stock/ETF entries are added to this repo, it's important to ensure they are consistently labelled so downstream consumers (e.g. MetaMask swap UI) can correctly identify and filter RWA tokens. Without this check, metadata entries with
(Ondo Tokenizedin the name could be merged without a label, leading to inconsistent data.What this workflow does
namecontains(Ondo Tokenized), checks that:labels/labelsarrayExample failure output
Notes
eip155:1,eip155:56,solana:*, etc.) since themetadata/→labels/path substitution is chain-agnosticNote
Low Risk
CI-only validation with no runtime or data-path changes; scope is limited to PR diffs.
Overview
Adds a pull-request GitHub Actions job that enforces label coverage for newly changed Ondo RWA metadata.
On each PR it collects added or modified
metadata/**/*.jsonfiles (vs the base branch), and for any whosenamecontains(Ondo Tokenized)it requires a parallel file underlabels/(same path withmetadata/swapped) with a non-emptylabelsarray. Failures print actionable guidance, includingnpm run asset:set -- --caip <caip> --labels "ondo". Pre-existing unlabelled tokens on the default branch are not scanned.Reviewed by Cursor Bugbot for commit 25db382. Bugbot is set up for automated code reviews on this repo. Configure here.