Skip to content

Fix potential out-of-bounds memory in IdealClusterBuilder #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvami merged 2 commits into from
Jun 17, 2026
Merged

Fix potential out-of-bounds memory in IdealClusterBuilder #2079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
671af95
Fix potential out-of-bounds memory in IdealClusterBuilder
tvami Jun 16, 2026
f31d0da
Add clear as Tom suggested
tvami Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions Trigger/Algo/src/Trigger/IdealClusterBuilder.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,8 @@ void ClusterGeometry::addTp(int tid, int cell_id, int module_id, float x,
positions_[tid] = std::make_pair(x, y);
}
void ClusterGeometry::addNeighbor(int id1, int id2) {
if (neighbors_.count(id1))
neighbors_[id1].push_back(id2);
else
neighbors_[id1] = {id2};
if (neighbors_.count(id2))
neighbors_[id2].push_back(id1);
else
neighbors_[id2] = {id1};
neighbors_[id1].push_back(id2);
neighbors_[id2].push_back(id1);
// cout << "Nbs: " << id1 << " " << id2 << endl;
}
bool ClusterGeometry::checkNeighbor(int id1, int id2) {
Expand Down Expand Up @@ -118,10 +112,7 @@ std::vector<Cluster> IdealClusterBuilder::build2dClustersLayer(
auto iclus = clus2hit_id.first;
auto& hit_i_ds = clus2hit_id.second;
for (const auto& hit_id : hit_i_ds) {
if (assoc_hit_i_d2clusters.count(hit_id))
assoc_hit_i_d2clusters[hit_id].push_back(iclus);
else
assoc_hit_i_d2clusters[hit_id] = {iclus};
assoc_hit_i_d2clusters[hit_id].push_back(iclus);
}
}

Expand Down Expand Up @@ -271,7 +262,8 @@ void IdealClusterBuilder::build3dClusters() {
}
// cout << "got seed" << endl;
// found seed
cluster3d.clusters2d_ = {clusters2d[0]};
cluster3d.clusters2d_.clear();
cluster3d.clusters2d_.push_back(clusters2d[0]);
Comment thread
tvami marked this conversation as resolved.
cluster3d.first_layer_ = test_layer;
cluster3d.last_layer_ = test_layer;
cluster3d.depth_ = 1;
Expand Down