Skip to content

Added OUTLINE_CARDINAL to match https://github.com/HaxeFlixel/flixel/… #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TracedInPurple wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added OUTLINE_CARDINAL to match https://github.com/HaxeFlixel/flixel/… #300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a7931e
Added OUTLINE_CARDINAL to match https://github.com/HaxeFlixel/flixel/…
TracedInPurple May 5, 2026
2657c3c
Apply suggestion from @Geokureli
Geokureli May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions flixel/addons/ui/FlxInputText.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,11 @@ class FlxInputText extends FlxText
caret.offset.x = shadowX < 0 ? -shadowX : 0;
caret.offset.y = shadowY < 0 ? -shadowY : 0;
#end
#if (flixel < version("6.2.0"))
case OUTLINE_FAST, OUTLINE:
#else
case OUTLINE_FAST, OUTLINE, OUTLINE_CARDINAL:
Copy link
Copy Markdown
Member

@Geokureli Geokureli May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a default case to prevent further CI issues in flixel-ui. Flixel-UI is no longer maintained but we're not ready to remove it from CI just yet as some demos still use it.

specifically add this to the end of the switch

				case unhandled:
					throw 'Unhandled borderStyle: $unhandled';
			}

Comment thread
Geokureli marked this conversation as resolved.
#end
// Border all around it
final absSize = Math.abs(borderSize);
cw += Std.int(absSize * 2);
Expand Down