Added OUTLINE_CARDINAL to match https://github.com/HaxeFlixel/flixel/…#300
Open
TracedInPurple wants to merge 2 commits into
Open
Added OUTLINE_CARDINAL to match https://github.com/HaxeFlixel/flixel/…#300TracedInPurple wants to merge 2 commits into
TracedInPurple wants to merge 2 commits into
Conversation
Geokureli
requested changes
May 5, 2026
| caret.offset.y = shadowY < 0 ? -shadowY : 0; | ||
| #end | ||
| case OUTLINE_FAST, OUTLINE: | ||
| case OUTLINE_FAST, OUTLINE, OUTLINE_CARDINAL: |
Member
There was a problem hiding this comment.
Please add a default case to prevent further CI issues in flixel-ui. Flixel-UI is no longer maintained but we're not ready to remove it from CI just yet as some demos still use it.
specifically add this to the end of the switch
case unhandled:
throw 'Unhandled borderStyle: $unhandled';
}
Geokureli
reviewed
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OUTLINE_CARDINAL is now also included to match with the changes made in
HaxeFlixel/flixel#3593