Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ services:

# Nginx is serving django static and media files and proxies to django and geonode
geonode:
image: geonode/nginx:1.28.0-v1
image: geonode/nginx:1.31.0-latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using mutable Docker image tags like 1.31.0-latest is discouraged as it makes deployments non-deterministic. Unlike the previous version 1.28.0-v1, which appeared to be a pinned revision, tags with the -latest suffix can be updated upstream, potentially leading to unexpected behavior or breaking changes without any modifications to this configuration. It is recommended to use a specific, immutable version tag.

    image: geonode/nginx:1.31.0

container_name: nginx4${COMPOSE_PROJECT_NAME}
env_file:
- .env
Expand Down
2 changes: 1 addition & 1 deletion docker-compose-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ services:

# Nginx is serving django static and media files and proxies to django and geonode
geonode:
image: geonode/nginx:1.28.0-v1
image: geonode/nginx:1.31.0-latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of the -latest suffix in the image tag introduces mutability. To ensure stability and reproducibility in your test environment, it is better to pin the image to a specific, immutable version. This prevents the environment from changing unexpectedly if the image is updated under the same tag.

    image: geonode/nginx:1.31.0

container_name: nginx4${COMPOSE_PROJECT_NAME}
env_file:
- .env_test
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ services:

# Nginx is serving django static and media files and proxies to django and geonode
geonode:
image: geonode/nginx:1.28.0-v1
image: geonode/nginx:1.31.0-latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Switching from a pinned version (1.28.0-v1) to a mutable tag (1.31.0-latest) reduces the reliability of the deployment. Mutable tags can lead to different image versions being pulled at different times, making it difficult to debug issues or roll back changes. Please consider using an immutable tag for the new version.

    image: geonode/nginx:1.31.0

container_name: nginx4${COMPOSE_PROJECT_NAME}
env_file:
- .env
Expand Down
Loading