Upgrade to NGINX 1.31.0#14226
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Nginx image version from 1.28.0-v1 to 1.31.0-latest across the development, test, and production Docker Compose configurations. The review feedback correctly identifies that using mutable tags like -latest can lead to non-deterministic deployments and recommends pinning the images to specific, immutable version tags to ensure stability and reproducibility.
| # Nginx is serving django static and media files and proxies to django and geonode | ||
| geonode: | ||
| image: geonode/nginx:1.28.0-v1 | ||
| image: geonode/nginx:1.31.0-latest |
There was a problem hiding this comment.
Using mutable Docker image tags like 1.31.0-latest is discouraged as it makes deployments non-deterministic. Unlike the previous version 1.28.0-v1, which appeared to be a pinned revision, tags with the -latest suffix can be updated upstream, potentially leading to unexpected behavior or breaking changes without any modifications to this configuration. It is recommended to use a specific, immutable version tag.
image: geonode/nginx:1.31.0| # Nginx is serving django static and media files and proxies to django and geonode | ||
| geonode: | ||
| image: geonode/nginx:1.28.0-v1 | ||
| image: geonode/nginx:1.31.0-latest |
There was a problem hiding this comment.
The use of the -latest suffix in the image tag introduces mutability. To ensure stability and reproducibility in your test environment, it is better to pin the image to a specific, immutable version. This prevents the environment from changing unexpectedly if the image is updated under the same tag.
image: geonode/nginx:1.31.0| # Nginx is serving django static and media files and proxies to django and geonode | ||
| geonode: | ||
| image: geonode/nginx:1.28.0-v1 | ||
| image: geonode/nginx:1.31.0-latest |
There was a problem hiding this comment.
Switching from a pinned version (1.28.0-v1) to a mutable tag (1.31.0-latest) reduces the reliability of the deployment. Mutable tags can lead to different image versions being pulled at different times, making it difficult to debug issues or roll back changes. Please consider using an immutable tag for the new version.
image: geonode/nginx:1.31.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14226 +/- ##
==========================================
+ Coverage 74.76% 74.91% +0.14%
==========================================
Files 967 975 +8
Lines 59351 59877 +526
Branches 8069 8152 +83
==========================================
+ Hits 44375 44858 +483
- Misses 13169 13195 +26
- Partials 1807 1824 +17 🚀 New features to boost your workflow:
|
(cherry picked from commit d27537e)
(cherry picked from commit d27537e)
2 participants
No description provided.