Skip to content

Fix stuck Save loading state when cancelling travel monthly limit reduction #99344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MelvinBot wants to merge 4 commits into
base: main
Choose a base branch
from
+169 −0
Draft

Fix stuck Save loading state when cancelling travel monthly limit reduction #99344

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a98065c
Disable instant press-loading on travel billing monthly limit form
MelvinBot Aug 24, 2026
7614984
Add regression tests for cancelling vs confirming travel monthly limi…
MelvinBot Aug 25, 2026
303db93
Fix: run oxfmt on WorkspaceTravelBillingMonthlyLimitPageTest to fix i…
MelvinBot Aug 25, 2026
336fc3d
Type jest.requireActual for TravelBilling mock and drop eslint-disables
MelvinBot Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pages/workspace/travel/WorkspaceTravelBillingMonthlyLimitPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ function WorkspaceTravelBillingMonthlyLimitPage({route}: WorkspaceTravelBillingM
enabledWhenOffline
shouldHideFixErrorsAlert
addBottomSafeAreaPadding
shouldShowLoadingImmediatelyOnPress={false}

@nyomanjyotisa nyomanjyotisa Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot Could you please add focused regression coverage verifying that Cancel leaves the Save button enabled without updating the limit, while Confirm updates it and navigates back?

@nyomanjyotisa nyomanjyotisa Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved ✅

>
<View style={styles.mb4}>
<InputWrapper
Expand Down
Loading