Skip to content

feat: introduce riscv64 to linux and musllinux builds #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eshattow wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

feat: introduce riscv64 to linux and musllinux builds #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04-arm, ubuntu-latest, macos-latest]
os: [ubuntu-24.04-arm, ubuntu-24.04-riscv, ubuntu-latest, macos-latest]
musl: ["", "musllinux"]
Comment on lines 185 to 187
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-24.04-riscv is not a standard GitHub-hosted runner label, and this repo doesn’t appear to document or gate the requirement for a self-hosted RISC-V runner. Without a guard, CI will queue indefinitely/fail in forks or environments without that runner. Consider adding an if: condition (e.g., only run on the main repo) and/or documenting the expected runner labels in the workflow (or repository docs) so contributors understand the dependency.

Copilot uses AI. Check for mistakes.
exclude:
- os: macos-latest
Expand All @@ -201,7 +201,7 @@ jobs:
CIBW_BEFORE_ALL_LINUX: apt-get install -y gcc || yum install -y gcc || apk add gcc
CIBW_BUILD_VERBOSITY: 3
REQUIRE_CYTHON: 1
CIBW_ARCHS_LINUX: ${{ matrix.os == 'ubuntu-24.04-arm' && 'aarch64' || 'auto' }}
CIBW_ARCHS_LINUX: ${{ ( matrix.os == 'ubuntu-24.04-arm' && 'aarch64' ) || ( matrix.os == 'ubuntu-24.04-riscv' && 'riscv64' ) || 'auto' }}

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v4
with:
Expand Down
Loading