Skip to content

feat: introduce riscv64 to linux and musllinux builds#620

Open
eshattow wants to merge 1 commit intoBluetooth-Devices:mainfrom
eshattow:riscv64
Open

feat: introduce riscv64 to linux and musllinux builds#620
eshattow wants to merge 1 commit intoBluetooth-Devices:mainfrom
eshattow:riscv64

Conversation

@eshattow
Copy link
Copy Markdown

Adding RISC-V to build and publish, depends on (#619 tracking issue) use of https://riseproject-dev.github.io/riscv-runner/

@eshattow eshattow mentioned this pull request Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (58b364c) to head (c2f74e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   85.74%   85.68%   -0.06%     
==========================================
  Files          29       29              
  Lines        3487     3487              
  Branches      602      602              
==========================================
- Hits         2990     2988       -2     
- Misses        307      308       +1     
- Partials      190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 29, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing eshattow:riscv64 (c2f74e9) with main (58b364c)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a RISC-V (riscv64) build target into the wheel build workflow so Linux and musllinux wheels can be produced for that architecture.

Changes:

  • Add ubuntu-24.04-riscv to the build_wheels job matrix.
  • Configure CIBW_ARCHS_LINUX to select riscv64 when running on the RISC-V runner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines 182 to +186
name: Build wheels on ${{ matrix.os }} with arch ${{ matrix.arch }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04-arm, ubuntu-latest, macos-latest]
os: [ubuntu-24.04-arm, ubuntu-24.04-riscv, ubuntu-latest, macos-latest]
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrix.arch is referenced in the job name, but the matrix only defines os and musl, so the displayed job name will have a blank/null arch value. Consider either adding an explicit arch dimension to the matrix (and deriving runs-on/CIBW_ARCHS_LINUX from it), or removing with arch ${{ matrix.arch }} from the name to avoid confusion—especially now that multiple CPU architectures are being added.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml
Comment on lines 185 to 187
matrix:
os: [ubuntu-24.04-arm, ubuntu-latest, macos-latest]
os: [ubuntu-24.04-arm, ubuntu-24.04-riscv, ubuntu-latest, macos-latest]
musl: ["", "musllinux"]
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-24.04-riscv is not a standard GitHub-hosted runner label, and this repo doesn’t appear to document or gate the requirement for a self-hosted RISC-V runner. Without a guard, CI will queue indefinitely/fail in forks or environments without that runner. Consider adding an if: condition (e.g., only run on the main repo) and/or documenting the expected runner labels in the workflow (or repository docs) so contributors understand the dependency.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build for RISC-V

3 participants