feat: introduce riscv64 to linux and musllinux builds#620
feat: introduce riscv64 to linux and musllinux builds#620eshattow wants to merge 1 commit intoBluetooth-Devices:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
- Coverage 85.74% 85.68% -0.06%
==========================================
Files 29 29
Lines 3487 3487
Branches 602 602
==========================================
- Hits 2990 2988 -2
- Misses 307 308 +1
- Partials 190 191 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Introduces a RISC-V (riscv64) build target into the wheel build workflow so Linux and musllinux wheels can be produced for that architecture.
Changes:
- Add
ubuntu-24.04-riscvto thebuild_wheelsjob matrix. - Configure
CIBW_ARCHS_LINUXto selectriscv64when running on the RISC-V runner.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Build wheels on ${{ matrix.os }} with arch ${{ matrix.arch }} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-24.04-arm, ubuntu-latest, macos-latest] | ||
| os: [ubuntu-24.04-arm, ubuntu-24.04-riscv, ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
matrix.arch is referenced in the job name, but the matrix only defines os and musl, so the displayed job name will have a blank/null arch value. Consider either adding an explicit arch dimension to the matrix (and deriving runs-on/CIBW_ARCHS_LINUX from it), or removing with arch ${{ matrix.arch }} from the name to avoid confusion—especially now that multiple CPU architectures are being added.
| matrix: | ||
| os: [ubuntu-24.04-arm, ubuntu-latest, macos-latest] | ||
| os: [ubuntu-24.04-arm, ubuntu-24.04-riscv, ubuntu-latest, macos-latest] | ||
| musl: ["", "musllinux"] |
There was a problem hiding this comment.
ubuntu-24.04-riscv is not a standard GitHub-hosted runner label, and this repo doesn’t appear to document or gate the requirement for a self-hosted RISC-V runner. Without a guard, CI will queue indefinitely/fail in forks or environments without that runner. Consider adding an if: condition (e.g., only run on the main repo) and/or documenting the expected runner labels in the workflow (or repository docs) so contributors understand the dependency.
Adding RISC-V to build and publish, depends on (#619 tracking issue) use of https://riseproject-dev.github.io/riscv-runner/