Skip to content

test(prover-node): make checkpoint store pruning test deterministic#24130

Merged
PhilWindle merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-checkpoint-store
Jun 16, 2026
Merged

test(prover-node): make checkpoint store pruning test deterministic#24130
PhilWindle merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-checkpoint-store

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes the merge-queue failure on PR feat: merge-train/spartan-v5 #24053 by making CheckpointStore's pruning test use explicit slots for its synthetic checkpoints.
  • The failed CI run was merge-group run 27616214374; CI3 job 81652669415 failed in x9-full (http://ci.aztec-labs.com/11cc1d3bfd3986cf).
  • The failing test was yarn-project/scripts/run_test.sh prover-node/src/checkpoint-store.test.ts, log http://ci.aztec-labs.com/0e7cfabe067f8bed, where markPrunedAboveBlock marks every prover holding a block above the target and returns them hit the stricter same-slot canonical checkpoint guard while building random test data.

Verification

  • git diff --check
  • ./bootstrap.sh ci attempted, but this branch's root bootstrap has no ci target and the container has no Docker socket.
  • ./bootstrap.sh ci-full-no-test-cache attempted to match the failed merge-queue leg, but local bootstrap failed before project tests because the test engine exited and interrupted the parallel build.
  • Focused Yarn/Jest verification is blocked in this checkout because yarn-project portal dependencies under noir/packages/* are not generated; noir/bootstrap.sh is blocked by a crates.io DNS/proxy failure while installing just.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 16, 2026
@PhilWindle PhilWindle marked this pull request as ready for review June 16, 2026 12:56
@PhilWindle PhilWindle enabled auto-merge (squash) June 16, 2026 12:56
@PhilWindle PhilWindle merged commit 566d37a into merge-train/spartan-v5 Jun 16, 2026
64 of 76 checks passed
@PhilWindle PhilWindle deleted the cb/fix-spartan-v5-checkpoint-store branch June 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants