Skip to content

fix(bb-sol): run forge tests with pinned solc#24133

Draft
AztecBot wants to merge 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-bb-sol-offline
Draft

fix(bb-sol): run forge tests with pinned solc#24133
AztecBot wants to merge 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-bb-sol-offline

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes the latest PR feat: merge-train/spartan-v5 #24053 dequeue cause after test(prover-node): make checkpoint store pruning test deterministic #24130: merge-group run 27623199860 failed in x2-full because forge test --no-match-contract Base attempted to resolve https://binaries.soliditylang.org/linux-amd64/list.json and hit a DNS failure.
  • Makes barretenberg/sol bootstrap export the pinned l1-contracts/solc-0.8.30 path for forge commands.
  • Makes the generated bb-sol CI test command download the pinned solc via l1-contracts/bootstrap.sh download_solc, then run forge with FOUNDRY_SOLC=../../l1-contracts/solc-0.8.30 and --offline.

Verification

  • git diff --check
  • ./bootstrap.sh ci attempted from repo root; this branch has no ci command (Unknown command: ci).
  • ./bootstrap.sh ci-full-no-test-cache attempted to match the failed merge-queue shard; local container stopped before bb-sol because .claude/tests/agents_symlink_test fails in this workspace and the test engine exits early.
  • ./bootstrap.sh in barretenberg/sol passed, generating VKs and compiling with Solc 0.8.30 offline.
  • FOUNDRY_SOLC=../../l1-contracts/solc-0.8.30 forge test --offline --no-match-contract Base passed: 168 tests, 0 failed.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant