-
Notifications
You must be signed in to change notification settings - Fork 5
[ci] Adjust ci.yml and __init__.py
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| """Verify backward compatibility of registration functions on Ray < 2.56. | ||
|
|
||
| These tests use mock to simulate the absence of | ||
| `ray.util.collective.backend_registry` (which was introduced in Ray 2.56), | ||
| ensuring that both registration functions raise RuntimeError with a clear | ||
| upgrade message instead of failing silently or crashing. | ||
| """ | ||
|
|
||
| from unittest.mock import patch | ||
|
|
||
| import pytest | ||
|
|
||
| from ray_ascend import register_hccl_collective_backend, register_hccl_tensor_transport | ||
|
|
||
|
|
||
| class TestBackwardCompatibility: | ||
| """Verify registration functions raise RuntimeError on Ray < 2.56.""" | ||
|
|
||
| @patch.dict("sys.modules", {"ray.util.collective.backend_registry": None}) | ||
| def test_register_hccl_collective_backend_raises_on_old_ray(self): | ||
| """register_hccl_collective_backend should raise RuntimeError when | ||
| backend_registry module is unavailable (Ray < 2.56).""" | ||
| with pytest.raises(RuntimeError, match="requires Ray >= 2.56"): | ||
| register_hccl_collective_backend() | ||
|
|
||
| @patch.dict("sys.modules", {"ray.util.collective.backend_registry": None}) | ||
| def test_register_hccl_tensor_transport_raises_on_old_ray(self): | ||
| """register_hccl_tensor_transport should raise RuntimeError when | ||
| backend_registry module is unavailable (Ray < 2.56). | ||
|
|
||
| It calls register_hccl_collective_backend first, so it inherits | ||
| the same RuntimeError behavior. | ||
| """ | ||
| with pytest.raises(RuntimeError, match="requires Ray >= 2.56"): | ||
| register_hccl_tensor_transport() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make
register_hccl_tensor_transportraisesRuntimeErrorlikeregister_hccl_collective_backendinstead ofImportedError.