[ci] Adjust ci.yml and __init__.py#66
Merged
Merged
Conversation
Signed-off-by: dpj135 <958208521@qq.com>
CLA Signature Passdpj135, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
KaisennHu
reviewed
Jun 4, 2026
Comment on lines
+160
to
+161
| register_hccl_collective_backend() | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
make register_hccl_tensor_transport raises RuntimeError like register_hccl_collective_backend instead of ImportedError.
tianyi-ge
reviewed
Jun 4, 2026
| run: | | ||
| echo "Running tests for Python ${{ matrix.python-version }}..." | ||
| python${{ matrix.python-version }} -m pytest -v tests/ | ||
| - name: Verify backward compatibility (Ray ${{ matrix.ray-version }}) |
Collaborator
There was a problem hiding this comment.
better add this script to tests as a unit test (only run if ray==2.55.0). It's not clear to maintain this script in workflow yaml
CLA Signature Passdpj135, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Signed-off-by: dpj135 <958208521@qq.com>
CLA Signature Passdpj135, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
tianyi-ge
approved these changes
Jun 10, 2026
Vito-Yang
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
ray_ascend/__init__.pyto makeregister_hccl_tensor_transportraisesRuntimeErrorlikeregister_hccl_collective_backendinstead ofImportedError.