Use codeflows for more context in SARIF output#1843
Merged
Conversation
Contributor
5 similar comments
Contributor
Contributor
Contributor
Contributor
Contributor
woodruffw
force-pushed
the
ww/better-sarif
branch
from
c978634 to
3e09608
Compare
Contributor
4 similar comments
Contributor
Contributor
Contributor
Contributor
woodruffw
commented
Apr 1, 2026
Comment on lines
+112
to
+117
| ThreadFlowLocation::builder() | ||
| .location(build_location(loc, None)) | ||
| // See: <https://github.com/psastras/sarif-rs/pull/972> | ||
| .importance(serde_json::Value::String(importance.into())) | ||
| .build() | ||
| }) |
Contributor
3 tasks
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
force-pushed
the
ww/better-sarif
branch
from
5869e06 to
95d3615
Compare
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches us from "related locations" to "code flows," which GitHub's SARIF viewer renders more reasonably. See #1840 for screenshots.
Separately, this also fixes the ref-version-mismatch description to make it less vague.
WIP, this is an experiment.Fixes #1840.