Skip to content

Basis optimization CLI #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfebrer wants to merge 9 commits into
base: main
Choose a base branch
from

added pyyaml as dependency

d900425
Select commit
Loading
Failed to load commit list.
Open

Basis optimization CLI #910

added pyyaml as dependency
d900425
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Jun 19, 2025 in 3s

10 new alerts including 1 error

New alerts in code changed by this pull request

  • 1 error
  • 4 warnings
  • 5 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 23 in src/sisl_toolbox/siesta/atom/_register_cli.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused global variable Note

The global variable '_script' is not used.

Check notice on line 378 in src/sisl_toolbox/siesta/minimizer/_minimize.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable opt is not used.

Check notice on line 379 in src/sisl_toolbox/siesta/minimizer/_minimize.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check failure on line 34 in src/sisl_toolbox/siesta/minimizer/_register_cli.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
Loading
.

Check notice on line 37 in src/sisl_toolbox/siesta/minimizer/basis_optimization.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check warning on line 68 in src/sisl_toolbox/siesta/minimizer/basis_optimization.py

See this annotation in the file changed.

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.

Check notice on line 247 in src/sisl_toolbox/siesta/minimizer/basis_optimization.py

See this annotation in the file changed.

Code scanning / CodeQL

Except block handles 'BaseException' Note

Except block directly handles BaseException.

Check warning on line 970 in src/sisl_toolbox/siesta/minimizer/basis_optimization.py

See this annotation in the file changed.

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.
This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.

Check warning on line 985 in src/sisl_toolbox/siesta/minimizer/basis_optimization.py

See this annotation in the file changed.

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.
This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.

Check warning on line 987 in src/sisl_toolbox/siesta/minimizer/basis_optimization.py

See this annotation in the file changed.

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.
This assignment to 'result' is unnecessary as it is
redefined
Loading
before this value is used.