fix: remove Required() from parameters with DefaultString() - #70
Open
vikasprogrammer wants to merge 1 commit into
Open
fix: remove Required() from parameters with DefaultString()#70vikasprogrammer wants to merge 1 commit into
vikasprogrammer wants to merge 1 commit into
Conversation
The MCP Go SDK does not apply default values when Required() is set and the client omits the field, causing validation errors like "parameter 'variety': is required". This removes Required() from variety, exchange, and quantity parameters that already have sensible defaults via DefaultString(), and updates the corresponding ValidateRequired() calls. Affected tools: place_order, modify_order, cancel_order, place_gtt_order, modify_gtt_order. Fixes zerodha#69 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp.Required()from parameters that havemcp.DefaultString()set (variety,exchange,quantity) across all order toolsRequired()is set and the client omits the field, causing validation errors likeparameter 'variety': is requiredValidateRequired()calls in handlers to matchAffected tools
place_order(variety, exchange, quantity)modify_order(variety)cancel_order(variety)place_gtt_order(exchange)modify_gtt_order(exchange)Fixes #69
Test plan
place_orderwithout specifyingvariety— should default to"regular"instead of erroringplace_orderwith explicitvarietyvalue — should still workcancel_orderandmodify_orderwithoutvariety— should default to"regular"exchange— should default to"NSE"🤖 Generated with Claude Code