Update README.md for cursor integration - #34
Open
mahecode wants to merge 1 commit into
Open
Conversation
Sundeepg98
added a commit
to Sundeepg98/kite-mcp-server
that referenced
this pull request
Apr 20, 2026
Task zerodha#34 — push DDD from ~93 to ~97. Replaces OrderSpec/QuantitySpec/ PriceSpec composition with the single kc/domain.NewOrderPlacement aggregate root (plus NewQuantity/NewMoney in modify's optional-change path). place_order.go: Execute now constructs NewOrderPlacement and fails fast if the aggregate rejects any invariant. Aggregate owns the {instrument, qty, price, txType, orderType} checks. modify_order.go: For quantity changes (cmd.Quantity > 0) — NewQuantity rejects <= 0. For price changes on non-MARKET/SL-M orders — NewMoney rejects <= 0. "0 means don't change" convention preserved. usecases_write_test.go (test-alignment per task brief): - TestPlaceOrder_ValidationFailures expectations now match aggregate error text ("requires a valid instrument", "requires a positive quantity"). Added explicit "empty exchange" case. - TestPlaceOrder_BrokerResolveError: exchange populated so the test reaches the broker-resolve step rather than the new aggregate gate. Full kc/usecases suite green. Diff <80 LOC incl. tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.