m_Do_main mostly matching for Wii versions#3165
Merged
Merged
Conversation
Report for GZ2J01 (db28ce3 - 7783c52)No changesReport for RZDE01_02 (db28ce3 - 7783c52)📈 Matched code: 54.67% (+0.01%, +1096 bytes) ✅ 8 new matches
📈 4 improvements in unmatched items
Report for ShieldD (db28ce3 - 7783c52)📈 Matched code: 54.45% (+0.00%, +596 bytes) ✅ 1 new match
📉 1 regression in an unmatched item
Report for Shield (db28ce3 - 7783c52)📈 Matched code: 50.27% (+0.01%, +624 bytes) ✅ 1 new match
📈 3 improvements in unmatched items
Report for GZ2P01 (db28ce3 - 7783c52)No changesReport for DZDE01 (db28ce3 - 7783c52)📈 Matched code: 52.21% (+0.02%, +1964 bytes) ✅ 15 new matches
📈 7 improvements in unmatched items
Report for RZDJ01 (db28ce3 - 7783c52)📈 Matched code: 53.84% (+0.01%, +1096 bytes) ✅ 8 new matches
📈 4 improvements in unmatched items
Report for RZDE01_00 (db28ce3 - 7783c52)📈 Matched code: 47.05% (+0.01%, +984 bytes) ✅ 8 new matches
📈 5 improvements in unmatched items
Report for GZ2E01 (db28ce3 - 7783c52)No changesReport for RZDP01 (db28ce3 - 7783c52)📈 Matched code: 53.71% (+0.01%, +1096 bytes) ✅ 9 new matches
📈 3 improvements in unmatched items
|
Contributor
Author
|
The regression in |
Contributor
Because we know the |
Contributor
Author
|
@LagoLunatic That's a good call, I've updated the branch with the change implemented. It doesn't seem to cause any regressions (after a small include change in |
TakaRikka
reviewed
Jun 20, 2026
Contributor
Author
|
All noted issues should be fixed and the branch has been rebased on latest main. |
TakaRikka
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly matches
m_Do_mainfor all Wii versions. The only remaining mismatches arecrclr cr1eqinstructions related to varargs calls. These can be fakematched for most versions by moving the vararg out to a variable, but this obviously breaks debug. I was able to link the file forRZDE01_02with these fakematches, and presumably at leastRZDJ01andRZDP01should also be linkable.RZDE01_00is a little trickier to fakematch, so I haven't managed to link that version at all.I've added a new PCH called
dolzel_minimalwhich currently only pulls inJKRHeap.h. This allows the fakeJKRHeap::dump_sortdefinition to be removed by fixing function ordering. I suspect this new PCH might be real in some capacity - the standard one won't work because the TU uses data pooling butZ2Calc::cNullVecand company aren't present, but at the same time I'm not aware of any other way to get MWCC to emit theJKRHeapfunction after__sinit.