fix(loader): restore legacy slash-prefixed class resolution for container:graph#262
Merged
zazoomauro merged 2 commits intoJun 23, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix container:graph to restore legacy /ClassName module resolution
fix(loader): restore legacy slash-prefixed class resolution for container:graph
Jun 22, 2026
zazoomauro
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service configs using slash-prefixed class references (e.g.
class: /Kernel) causecontainer:graphto throwCannot find module '/Kernel'because/Kernelis treated as an absolute filesystem path rather than a relative module name.Root cause
In
FileLoader._requireClassNameFromPath,path.isAbsolute('/Kernel')returnstrue, so_getFromDirectoryByClassObjectsetsfromDirectory = '/'. This makespath.join('/', '/Kernel') = '/Kernel', causingrequire('/Kernel')to fail as a bare absolute path with no corresponding file.Changes
lib/Loader/FileLoader.js— Normalize single-segment slash-prefixed class names at the entry of_requireClassNameFromPathbefore resolution:After normalization
Kernelresolves correctly relative to the config file's directory. Real absolute paths (multiple segments) are unaffected.test/Resources/config/slash-prefixed-class.yml+test/Resources/config/Kernel.js— Test fixtures for the legacy pattern.test/node-dependency-injection/lib/Loader/YamlFileLoader.spec.js— Regression test: load, compile, and resolve a service defined withclass: /Kernel.