Skip to content

problem-meta-schema.json: remove exclusiveMaximum for status - #1567

Merged
tkrop merged 2 commits into
mainfrom
problem-exclusive-maximum
Jul 8, 2026
Merged

problem-meta-schema.json: remove exclusiveMaximum for status#1567
tkrop merged 2 commits into
mainfrom
problem-exclusive-maximum

Conversation

@ePaul

@ePaul ePaul commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

We updated the schema to be compatible with the JSON schema version in OpenAPI 3.1, but forgot to update Zally.

@ePaul
ePaul requested a review from tkrop as a code owner July 8, 2026 09:10
@ePaul ePaul added area: rules bugfix Bug fixes and patches, e.g. fixing of a production issue that is affecting the customer experience. labels Jul 8, 2026
@ePaul

ePaul commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Failing test:

> Task :zally-ruleset-zalando:test

UseProblemJsonRuleTest > should return violation if a wrong schema is used for Problem Details Object() FAILED
    java.lang.AssertionError at UseProblemJsonRuleTest.kt:71

UseProblemJsonRuleTest > should return violation if a incorrect schema is used for Problem Details Object (OpenAPI 2)() FAILED
    java.lang.AssertionError at UseProblemJsonRuleTest.kt:109

I guess I'll need to actually check this out locally ...

@ePaul

ePaul commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

I'm not sure whether we should add a test that the old version still works?

@ePaul

ePaul commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

👍

1 similar comment
@aswinramesh

Copy link
Copy Markdown

👍

@tkrop
tkrop merged commit a160164 into main Jul 8, 2026
15 checks passed
@tkrop
tkrop deleted the problem-exclusive-maximum branch July 8, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: rules bugfix Bug fixes and patches, e.g. fixing of a production issue that is affecting the customer experience.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants