Skip to content

Editorial plugins: Plugins without hosts filters - #1967

Open
iLLiCiTiT wants to merge 18 commits into
developfrom
enhancement/editorial-plugins-without-hosts
Open

Editorial plugins: Plugins without hosts filters#1967
iLLiCiTiT wants to merge 18 commits into
developfrom
enhancement/editorial-plugins-without-hosts

Conversation

@iLLiCiTiT

@iLLiCiTiT iLLiCiTiT commented Jul 21, 2026

Copy link
Copy Markdown
Member

Changelog Description

Editorial plugins have 2 variants now. One plugin variant has old filters and the order has just families filter with very targeted families filtering to just one family.

Additional info

The goal is that hosts that do want to actually use any logic from the plugins should add the family to instance. That way the host is in charge if logic from core will be triggered instead of core knowing it. That way any change in existing integrations or new editorial host should not need to change core.

This is first step, second step would be to add the families in the host integrations and last step will be to remove the old plugins, that will require to bump compatible versions in package.py.

Affected hosts


Changes in plugins

CollectOtioReview

  • renamed to CollectOTIOReviewTrack
  • added one plugin with family "otio.review.track"
  • kept old for backwards compatibility
  • 'otioClip' is NOT automatically used if there is "review" in families !!!
  • 'otioReviewClips' can be pre-filled -> host integration can fill it to use otioClip !!!

CollectOtioRanges

  • added one plugin with family "otio.clip.ranges"
  • kept old for backwards compatibility

CollectOtioSubsetResources

  • renamed to CollectOTIOProductResources
  • added one plugin with family "otio.clip.resources"
  • kept old for backwards compatibility

ExtractOTIOFile

  • added one plugin with family "otio.timeline.workfile"
  • kept old for backwards compatibility

ExtractOTIOReview and ExtractOTIOTrimmingVideo

  • both just removed hosts and changed families to "otio.trim.review" "otio.trim.video"
  • the families are added by CollectOTIOProductResources

Testing notes:

Nothing should change with this PR.

Someone should look at the new families and make sure it makes sense.

The way how host integration tells core what to use for track review changed too.

We should try each host in this combinations:

  • core develop & host develop - to validate everything works
  • core PR & host develop - a debug log in each old plugin will be visible at the start
  • core develop & host PR - nothing that can be visualy validated
  • core PR & host PR - a debug log should not be visible

One plugin has old filters and the order has just families filter
@iLLiCiTiT iLLiCiTiT self-assigned this Jul 21, 2026
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Jul 21, 2026
@ynbot ynbot added the size/S label Jul 21, 2026

@rdelillo rdelillo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it all, and all combinaison in Flame. It works great including trimming and review.

Just added some additional debug logs.
Also see my comment regarding the remaning review family usage in collect_otio_review.

Comment thread client/ayon_core/plugins/publish/collect_otio_review.py
@ynbot ynbot moved this to Review In Progress in PR reviewing Jul 21, 2026
@iLLiCiTiT
iLLiCiTiT marked this pull request as ready for review July 22, 2026 08:08
@iLLiCiTiT

Copy link
Copy Markdown
Member Author

Logic of CollectOTIOReviewTrack was changed to be different from original CollectOtioReview. It does not auto-use otioClip for review if review track is not set and there is "review" family in families, instead the host can pre-fill "otioReviewClips" to use it.

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to more explicit families name I think is a good improvement.

I wish we could clean up the backwards compatibility some day though. 🗡️ Because that'd make this much prettier.

Comment thread client/ayon_core/plugins/publish/collect_otio_frame_ranges.py Outdated
Comment thread client/ayon_core/plugins/publish/collect_otio_frame_ranges.py
Comment thread client/ayon_core/plugins/publish/collect_otio_frame_ranges.py Outdated
Comment thread client/ayon_core/plugins/publish/collect_otio_product_resources.py Outdated

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks OK to me. Needs more testing across various integrations for editorial + also testing for backwards compatibility there.

@github-project-automation github-project-automation Bot moved this from Review In Progress to Merge Requested in PR reviewing Jul 28, 2026
@iLLiCiTiT

Copy link
Copy Markdown
Member Author

@rdelillo could you find time to test some of the other hosts too?

@rdelillo

rdelillo commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Update, all good for Resolve as well. The debug log when when plugins are skipped helps a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S type: enhancement Improvement of existing functionality or minor addition

Projects

Status: Merge Requested

Development

Successfully merging this pull request may close these issues.

4 participants