Editorial plugins: Plugins without hosts filters - #1967
Conversation
One plugin has old filters and the order has just families filter
|
Logic of CollectOTIOReviewTrack was changed to be different from original CollectOtioReview. It does not auto-use |
BigRoy
left a comment
There was a problem hiding this comment.
Change to more explicit families name I think is a good improvement.
I wish we could clean up the backwards compatibility some day though. 🗡️ Because that'd make this much prettier.
BigRoy
left a comment
There was a problem hiding this comment.
Code-wise looks OK to me. Needs more testing across various integrations for editorial + also testing for backwards compatibility there.
|
@rdelillo could you find time to test some of the other hosts too? |
|
Update, all good for Resolve as well. The debug log when when plugins are skipped helps a lot. |
Changelog Description
Editorial plugins have 2 variants now. One plugin variant has old filters and the order has just families filter with very targeted families filtering to just one family.
Additional info
The goal is that hosts that do want to actually use any logic from the plugins should add the family to instance. That way the host is in charge if logic from core will be triggered instead of core knowing it. That way any change in existing integrations or new editorial host should not need to change core.
This is first step, second step would be to add the families in the host integrations and last step will be to remove the old plugins, that will require to bump compatible versions in package.py.
Affected hosts
Changes in plugins
CollectOtioReview
"otio.review.track"otioClip!!!CollectOtioRanges
"otio.clip.ranges"CollectOtioSubsetResources
"otio.clip.resources"ExtractOTIOFile
"otio.timeline.workfile"ExtractOTIOReview and ExtractOTIOTrimmingVideo
hostsand changedfamiliesto"otio.trim.review""otio.trim.video"CollectOTIOProductResourcesTesting notes:
Nothing should change with this PR.
Someone should look at the new families and make sure it makes sense.
The way how host integration tells core what to use for track review changed too.
We should try each host in this combinations: