enhancement: attach image/video file from disk as workfile review - #315
Open
sidmehraajm wants to merge 1 commit into
Open
enhancement: attach image/video file from disk as workfile review#315sidmehraajm wants to merge 1 commit into
sidmehraajm wants to merge 1 commit into
Conversation
Add ExtractWorkfileReviewFromFile publish plugin that exposes a 'Review file' file picker on the Workfile instance. The selected image or video is attached to the workfile product as a 'review'-tagged representation and a thumbnail is generated from it, so a review can be published without rendering a camera/playblast. Leaving the field empty is a no-op.
Member
|
Admittedly, I think this has no reason of being inside Blender - it may very well apply nearly as much across most integrations (if not all) which makes me think whether there's any reason to not move something akin to this into AYON-core. It applies to a much wider use case - and it's not blender-specific? What type of videos are you attaching? Where do they come from? Are they manually made from the scene-file? Because if so, isn't the end goal instead that we automate that generation? Also, with that said - I feel this is also a fine addition to just a custom studio addon which makes me wonder whether there's actually a place for this out of the box in AYON. Seems rather specific to a preference of doing this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ExtractWorkfileReviewFromFile publish plugin that exposes a 'Review file' file picker on the Workfile instance. The selected image or video is attached to the workfile product as a 'review'-tagged representation and a thumbnail is generated from it, so a review can be published without rendering a camera/playblast. Leaving the field empty is a no-op.
Changelog Description
Brief description of the solution this PR is implementing. This should be only a few sentences and it will be publicly visible in the changelog. You can highlight importance of the change and add links to further information or supporting documentation
Additional review information
Detailed information of the changes made to the product or service, providing an in-depth description of the updates and enhancements. This can include technical information, code examples and anything else needed for the review of the PR.
Testing notes: