This repository was archived by the owner on Dec 1, 2025. It is now read-only.
Fix wait for tailscale - #2
Open
prognostikos wants to merge 3 commits into
Open
Conversation
prognostikos
force-pushed
the
fix-wait-for-tailscale
branch
from
May 16, 2025 11:20
fdda0b7 to
879571d
Compare
The Heroku-24 stack does not include `bc` and bash cannot do non-integer math. Use `awk` to convert the timeout & interval to milliseconds so we can use build-in bash math operators.
prognostikos
force-pushed
the
fix-wait-for-tailscale
branch
from
May 16, 2025 12:28
879571d to
7368b9c
Compare
Author
|
Took a few attempts to get a working version but should be good now. |
Author
|
Oddly enough I don't think the original code ever worked as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heroku's 24 stack does not include
bc, so waiting for tailscale to be up does not work. This PR changes the function to use awk for the calculation.In addition I've added the ability to configure the timeout by setting
TAILSCALE_RUNNING_TIMEOUTin the environment.