Fix #888 issue

src/Command/AbstractCommand.php

@@ -208,6 +208,7 @@ public function batchInsert(string $table, array $columns, iterable $rows): stat
 
     public function insertBatch(string $table, iterable $rows, array $columns = []): static
     {
+        //mark this as deprecated and remove in future versions
         $table = $this->getQueryBuilder()->getQuoter()->getRawTableName($table);
 
         $params = [];

src/Command/CommandsCollection.php

@@ -0,0 +1,111 @@
+<?php
+namespace Yiisoft\Db\Command;
+
+use Iterator;
+use Countable;
+use Yiisoft\Db\Connection\ConnectionInterface;
+use Yiisoft\Db\Exception\Exception;
+use Yiisoft\Db\Exception\InvalidConfigException;
+
+class CommandsCollection implements Iterator, Countable
+{
+    /**
+     * @var int Current iterator position
+     */
+    private int $position = 0;
+    /**
+     * @var CommandInterface[] Command of the collection
+     */
+    private array $commands = [];
+
+    /**
+     * @param ConnectionInterface $connection Connection to a database
+     */
+    public function __construct(private readonly ConnectionInterface $connection)
+    {
+    }
+
+    function rewind(): void {
+        $this->position = 0;
+    }
+
+    function current(): CommandInterface {
+        return $this->commands[$this->position];
+    }
+
+    function key(): int {
+        return $this->position;
+    }
+
+    function next(): void {
+        ++$this->position;
+    }
+
+    function valid(): bool {
+        return isset($this->commands[$this->position]);
+    }
+
+    function count(): int
+    {
+        return count($this->commands);
+    }
+
+    /**
+     * @throws InvalidConfigException
+     * @throws Exception
+     */
+    public function insertBatch(string $table, array $rows, array $columns = []): static
+    {
+        $table = $this->connection->getQuoter()->getRawTableName($table);
+
+        $columnsCount = count($columns);
+        if ($columnsCount === 0 && count($rows) > 0) {
+            $columnsCount = count(array_keys($rows[array_key_first($rows)]));
+        }
+
+        $maxParamsQty = $this->connection->getParamsLimit();
+        $totalInsertedParams = $columnsCount * count($rows);
+
+        if (!empty($maxParamsQty) && $totalInsertedParams > $maxParamsQty) {
+            $chunkSize = (int)floor($maxParamsQty / $columnsCount);
+            $rowChunks = array_chunk($rows, $chunkSize);
+            foreach ($rowChunks as $rowChunk) {
+                $this->commands[] = $this->createInsertBatchCommand($table, $rowChunk, $columns);
+            }
+        } else {
+            $this->commands[] = $this->createInsertBatchCommand($table, $rows, $columns);
+        }
+
+        return $this;
+    }
+
+    /**
+     * @throws InvalidConfigException
+     * @throws Exception
+     */
+    private function createInsertBatchCommand(string $table, array $rows, array $columns = []): CommandInterface
+    {
+        $command = $this->connection->createCommand();
+        $params = [];
+        $sql = $this->connection->getQueryBuilder()->insertBatch($table, $rows, $columns, $params);
+
+        $command->setRawSql($sql);
+        $command->bindValues($params);
+
+        return $command;
+    }
+
+    /**
+     * @throws \Throwable
+     * @throws Exception
+     */
+    public function execute(): int
+    {
+        $total = 0;
+        foreach ($this->commands as $command) {
+            $total += $command->execute();
+        }
+
+        return $total;
+    }
+}

src/Connection/AbstractConnection.php

@@ -6,6 +6,7 @@
 
 use Closure;
 use Throwable;
+use Yiisoft\Db\Command\CommandsCollection;
 use Yiisoft\Db\Query\BatchQueryResult;
 use Yiisoft\Db\Query\BatchQueryResultInterface;
 use Yiisoft\Db\Query\QueryInterface;
@@ -117,4 +118,18 @@ protected function rollbackTransactionOnLevel(TransactionInterface $transaction,
             }
         }
     }
+
+    public function getParamsLimit(): int
+    {
+        //must be overriden in a DBMS package which has a limit
+        if ($this->getDriverName() === 'pgsql') {
+            return 65535;
+        }
+        return 0;
+    }
+
+    public function createCommandsCollection(): CommandsCollection
+    {
+        return new CommandsCollection($this);
+    }
 }

src/Connection/ConnectionInterface.php

@@ -7,6 +7,7 @@
 use Closure;
 use Throwable;
 use Yiisoft\Db\Command\CommandInterface;
+use Yiisoft\Db\Command\CommandsCollection;
 use Yiisoft\Db\Exception\Exception;
 use Yiisoft\Db\Exception\InvalidCallException;
 use Yiisoft\Db\Exception\InvalidConfigException;
@@ -228,4 +229,16 @@ public function setTablePrefix(string $value): void;
      * @psalm-param Closure(ConnectionInterface):mixed|Closure(ConnectionInterface):void $closure
      */
     public function transaction(Closure $closure, ?string $isolationLevel = null): mixed;
+
+    /**
+     * Returns maximum number of bound params for a DBMS. Default 0 - means unlimited.
+     * @return int
+     */
+    public function getParamsLimit(): int;
+
+    /**
+     * Creates commands collection used for `insertBatch()`
+     * @return CommandsCollection
+     */
+    public function createCommandsCollection(): CommandsCollection;
 }

tests/AbstractCommandTest.php

@@ -9,11 +9,13 @@
 use Yiisoft\Db\Command\Param;
 use Yiisoft\Db\Command\ParamInterface;
 use Yiisoft\Db\Exception\Exception;
+use Yiisoft\Db\Exception\IntegrityException;
 use Yiisoft\Db\Exception\InvalidConfigException;
 use Yiisoft\Db\Exception\NotSupportedException;
 use Yiisoft\Db\Profiler\Context\CommandContext;
 use Yiisoft\Db\Profiler\ContextInterface;
 use Yiisoft\Db\Profiler\ProfilerInterface;
+use Yiisoft\Db\Schema\Column\ColumnBuilder;
 use Yiisoft\Db\Tests\Support\DbHelper;
 use Yiisoft\Db\Tests\Support\TestTrait;
 
@@ -48,6 +50,7 @@ public function testAutoQuoting(): void
             ),
             $command->getSql(),
         );
+        $db->close();
     }
 
     /**
@@ -69,6 +72,7 @@ public function testConstruct(): void
 
         $this->assertSame($sql, $command->getSql());
         $this->assertSame([':name' => 'John Doe'], $command->getParams());
+        $db->close();
     }
 
     /**
@@ -106,6 +110,7 @@ public function testGetParams(): void
         $this->assertContainsOnlyInstancesOf(ParamInterface::class, $bindedValues);
         $this->assertCount(3, $bindedValues);
         $this->assertEquals($param, $bindedValues['int']);
+        $db->close();
     }
 
     /**
@@ -127,6 +132,7 @@ public function testGetRawSql(string $sql, array $params, string $expectedRawSql
         $command = $db->createCommand($sql, $params);
 
         $this->assertSame($expectedRawSql, $command->getRawSql());
+        $db->close();
     }
 
     /**
@@ -148,6 +154,7 @@ public function testGetSetSql(): void
         SQL;
         $command->setSql($sql2);
         $this->assertSame($sql2, $command->getSql());
+        $db->close();
     }
 
     /**
@@ -174,6 +181,7 @@ public function testPrepareCancel(): void
         $command->cancel();
 
         $this->assertNull($command->getPdoStatement());
+        $db->close();
     }
 
     /**
@@ -193,6 +201,7 @@ public function testSetRawSql(): void
         );
 
         $this->assertSame('SELECT 123', $command->getRawSql());
+        $db->close();
     }
 
     /**
@@ -211,6 +220,7 @@ public function testSetSql(): void
         );
 
         $this->assertSame('SELECT 123', $command->getSql());
+        $db->close();
     }
 
     /**
@@ -236,6 +246,7 @@ public function testProfiler(?string $sql = null): void
         $db->setProfiler($profiler);
 
         $db->createCommand($sql)->execute();
+        $db->close();
     }
 
     /**
@@ -276,5 +287,57 @@ public function end(string $token, ContextInterface|array $context = []): void
         $db->setProfiler($profiler);
 
         $db->createCommand($sql)->execute();
+        $db->close();
+    }
+
+    public function testBindParamsOverflowIssue(): void
+    {
+        $db = $this->getConnection();
+
+        if ($db->getDriverName() !== 'pgsql') {
+            $this->markTestSkipped('Test is intended for use with pgsql database.');
+        }
+
+//        $skipVersions = ['11', '12', '16'];
+//        $dbmsVersion = $db->getServerInfo()->getVersion();
+//        if (preg_match('/^(\d+)\.(\d+)/ui', $dbmsVersion, $matches)) {
+//            $dbmsVersion = $matches[1];
+//        }
+//        if (in_array($dbmsVersion, $skipVersions)) {
+//            $this->markTestSkipped('Test is not applicable to pgsql v' . $dbmsVersion);
+//        }
+
+        $tempTableName = 'testTempTable';
+        $db->createCommand()->createTable($tempTableName, [
+            'id' => ColumnBuilder::primaryKey(),
+            'first_name' => ColumnBuilder::string()->notNull(),
+            'last_name' => ColumnBuilder::string()->notNull(),
+            'birth_date' => ColumnBuilder::date(),
+            'country' => ColumnBuilder::string(),
+            'city' => ColumnBuilder::string(),
+            'address' => ColumnBuilder::string(),
+        ])->execute();
+
+        $personData = [
+            'first_name' => 'IVAN',
+            'last_name' => 'PUPKIN',
+            'birth_date' => '1983-08-08',
+            'country' => 'Kazakhstan',
+            'city' => 'Almaty',
+            'address' => '7, Gagarin street, apartment 10',
+        ];
+
+        //generate 66 000 params (6 fields x 11000 lines)
+        $insertData = [];
+        for ($i = 0; $i < 11000; $i++) {
+            $insertData[] = $personData;
+        }
+
+        $db->createCommandsCollection()->insertBatch($tempTableName, $insertData)->execute();
+
+        $countSql = 'SELECT COUNT(*) FROM ' . $db->getQuoter()->quoteTableName($tempTableName);
+        $this->assertEquals(11000, $db->createCommand($countSql)->queryScalar());
+        $db->createCommand()->dropTable($tempTableName)->execute();
+        $db->close();
     }
 }

tests/AbstractConnectionTest.php

@@ -37,6 +37,7 @@ public function testCreateBatchQueryResult(): void
         $query = (new Query($db))->from('customer');
 
         $this->assertInstanceOf(BatchQueryResult::class, $db->createBatchQueryResult($query));
+        $db->close();
     }
 
     /**
@@ -56,13 +57,15 @@ public function testCreateCommand(): void
 
         $this->assertSame($sql, $command->getSql());
         $this->assertSame($params, $command->getParams());
+        $db->close();
     }
 
     public function testGetDriverName(): void
     {
         $db = $this->getConnection();
 
         $this->assertSame($this->getDriverName(), $db->getDriverName());
+        $db->close();
     }
 
     /**
@@ -84,6 +87,7 @@ function (PdoConnectionInterface $db) {
                 $db->beginTransaction();
             }
         );
+        $db->close();
     }
 
     public function testNotProfiler(): void
@@ -101,6 +105,7 @@ public function testNotProfiler(): void
         $db->setProfiler(null);
 
         $this->assertNull(Assert::getInaccessibleProperty($db, 'profiler'));
+        $db->close();
     }
 
     public function testProfiler(): void
@@ -128,6 +133,7 @@ public function end(string $token, ContextInterface|array $context = []): void
         };
         $db->setProfiler($profiler);
         $db->open();
+        $db->close();
     }
 
     public function testSetTablePrefix(): void
@@ -137,6 +143,7 @@ public function testSetTablePrefix(): void
         $db->setTablePrefix('pre_');
 
         $this->assertSame('pre_', $db->getTablePrefix());
+        $db->close();
     }
 
     public function testSerialized(): void
@@ -151,6 +158,7 @@ public function testSerialized(): void
         $this->assertNull($unserialized->getPDO());
         $this->assertEquals(123, $unserialized->createCommand('SELECT 123')->queryScalar());
         $this->assertNotNull($connection->getPDO());
+        $connection->close();
     }
 
     private function getProfiler(): ProfilerInterface