Fix: move typing_extensions import under TYPE_CHECKING#38
Merged
Conversation
…2.x on Python 3.12+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37.
cursors.pyimportedSelffromtyping_extensionsat module level, buttyping-extensionswas not declared as an explicit dependency. This broke with Poetry 2.x on Python 3.12+, where the package is not installed (its marker is computed aspython_version < "3.11"from transitive deps).Fix: since
from __future__ import annotationsis already present,Selfis only used in type annotations that are never evaluated at runtime. Moving the import underif TYPE_CHECKING:eliminates the runtime dependency entirely — no changes topyproject.tomlneeded.Changes
ydb_dbapi/cursors.py: movedfrom typing_extensions import Selfunderif TYPE_CHECKING:Test plan
python -c "import ydb_dbapi"succeeds on Python 3.12+ withouttyping-extensionsinstalledruff checkpassesmypypasses