fix(wasm): return error instead of silently ignoring encryption_key#3798
Open
Sertug17 wants to merge 1 commit into
Open
fix(wasm): return error instead of silently ignoring encryption_key#3798Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
When encryption_key is provided in WASM builds, return a JsError instead of logging a warning and creating an unencrypted database. The previous behavior silently exposed sensitive message data in plaintext without the caller's knowledge. Closes xmtp#3797
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3797
Note
Return error when
encryption_keyis provided in WASM buildsPreviously,
build_storein the WASM client silently ignoredencryption_keywith a warning log. It now returns aJsErrorimmediately, making the unsupported option visible to callers. Behavioral Change: any WASM code that passesencryption_keywill now receive an error instead of proceeding silently.Macroscope summarized 52a721d.