fix: handle non-multiple-of-4 inputs in histogram_i32x4_kernel#425
Open
Ajith-Kumar-Nelliparthi wants to merge 1 commit into
Open
fix: handle non-multiple-of-4 inputs in histogram_i32x4_kernel#425Ajith-Kumar-Nelliparthi wants to merge 1 commit into
Ajith-Kumar-Nelliparthi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix histogram_i32x4_kernel boundary handling
Problem
The current implementation loads 4 integers unconditionally using INT4(a[idx]).
When N is not divisible by 4, the kernel may read out of bounds because only idx < N is checked.
Fix
Added a safe fast path for full int4 loads using:
if ((idx + 3) < N)
Added tail handling for remaining 1-3 elements.
Result
This prevents out-of-bounds memory accesses for non-multiple-of-4 input sizes while preserving the vectorized fast path.