fix(jdbc): escape table type values in getTables metadata query#1426
Open
dxbjavid wants to merge 1 commit into
Open
fix(jdbc): escape table type values in getTables metadata query#1426dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the types argument passed to getTables is interpolated straight into the TABLE_TYPE IN (...) list without escape(), unlike the other identifiers used in these metadata queries, so a type value containing a single quote breaks the generated SQL and can change what the query returns (for instance a value like "X') OR ('1'='1" bypasses the type filter and lists every table). passing each value through escape() keeps embedded quotes literal, in line with the recent getColumns change. i added a small regression test next to the existing metadata quote tests.