fix!: Update content and unlisted script globalName default to false - #2511
Merged
Conversation
aklinker1
marked this pull request as ready for review
July 26, 2026 16:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## major #2511 +/- ##
==========================================
+ Coverage 79.31% 79.36% +0.05%
==========================================
Files 131 131
Lines 3969 3969
Branches 905 905
==========================================
+ Hits 3148 3150 +2
+ Misses 730 728 -2
Partials 91 91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aklinker1
added a commit
that referenced
this pull request
Jul 26, 2026
…se` (#2511) BREAKING CHANGE: If your script needs to return a value, like for `browser.scripting.executeScript`, set `globalName: true` to maintain the old behavior.
aklinker1
added a commit
that referenced
this pull request
Jul 26, 2026
…se` (#2511) BREAKING CHANGE: If your script needs to return a value, like for `browser.scripting.executeScript`, set `globalName: true` to maintain the old behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
BREAKING CHANGE: If your script needs to return a value, like for
browser.scripting.executeScript, setglobalName: trueto maintain the old behavior.Overview
Don't generate IIFE global variable for content and unlisted scripts by default. This prevents generating extra code when a return value isn't necessary.
This closes #2156