fix: docs sidebar header, background color issue - #2504
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
==========================================
- Coverage 79.40% 79.35% -0.05%
==========================================
Files 134 134
Lines 4005 4005
Branches 910 910
==========================================
- Hits 3180 3178 -2
- Misses 735 736 +1
- Partials 90 91 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What? It doesn't solve #2503 and why this background?
|
My bad, I only checked in Guides page. |
|
@PatrykKuniczak Now can you check, a prefix class was missing, now it only applies to that particular part. |
|
@nishu-murmu But why are you changing background to fix #2503 ?? |
|
@PatrykKuniczak applying z-index isn't causing anything. I've added more specific header class for that. |
|
@nishu-murmu There's no bug for me, at all, i don't know what are you're trying to fix guys. |
|
@PatrykKuniczak The text is overlapping. |
|
@nishu-murmu I can't see your .bmp files, let's attach it directly there in other format. |
@PatrykKuniczak I'm talking about the sidebar header, when you scroll the sidebar, those texts gets overlapped. |
|
@nishu-murmu Ok, now i see. But still there's a problem: There shouldn't be dark bg, it should be only on sidebar. |
|
@PatrykKuniczak which page?, can you please provide entire page screenshot? |
https://deploy-preview-2504--creative-fairy-df92c4.netlify.app/guide/installation.html |
|
@PatrykKuniczak I was looking completely else where for the fix 😅 . |
|
Thanks for helping make WXT better! |
@nishu-murmu If you won't have that messages in next PRs, you can add yourself there: wxt/.github/workflows/pr-closed.yml Lines 25 to 32 in eb93fa4 |
|
@PatrykKuniczak cool, thanks for letting me know. |
|
This should be Also, this isn't a bug in vitepress by default, we introduced it in some custom style. That means the solution should have been to remove the style causing the issue, not add another one. At least, that was my initial thought, I didn't investigate and could be wrong. Neither of these is a big deal, just an FYI for the future. |
|
@aklinker1 Thanks for pointing it out! Will make sure of that next time. |
|
@aklinker1 OOO yeah
My fault, i've seen that in the start and i've plan to change it. |
|
@aklinker1 If we'll change title now, on release this PR goes into "dosc" section, or it's basing on merge commits? |






Overview
Added a class in
custom.cssfor sidebar headerManual Testing
bun docs:dev.http://localhost:5173/guide/resources/how-wxt-works.htmlRelated Issue
This PR closes #2503