Skip to content

fix: docs sidebar header, background color issue - #2504

Merged
PatrykKuniczak merged 4 commits into
mainfrom
fix/sidebar-overlay-issue
Jul 26, 2026
Merged

fix: docs sidebar header, background color issue#2504
PatrykKuniczak merged 4 commits into
mainfrom
fix/sidebar-overlay-issue

Conversation

@nishu-murmu

Copy link
Copy Markdown
Collaborator

Overview

Added a class in custom.css for sidebar header

Manual Testing

  1. run locally bun docs:dev.
  2. Check for this path http://localhost:5173/guide/resources/how-wxt-works.html

Related Issue

This PR closes #2503

@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit aa832f3
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a65bb21a32b350008498044
😎 Deploy Preview https://deploy-preview-2504--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@nishu-murmu nishu-murmu changed the title fix: docs sidebar header, background color issue. fix: docs sidebar header, background color issue Jul 25, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jul 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2504

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2504

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2504

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2504

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2504

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2504

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2504

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2504

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2504

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2504

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2504

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2504

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2504

wxt

npm i https://pkg.pr.new/wxt@2504

commit: aa832f3

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.35%. Comparing base (5bd36e9) to head (aa832f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
- Coverage   79.40%   79.35%   -0.05%     
==========================================
  Files         134      134              
  Lines        4005     4005              
  Branches      910      910              
==========================================
- Hits         3180     3178       -2     
- Misses        735      736       +1     
- Partials       90       91       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

What?

It doesn't solve #2503 and why this background?
It doesn't look good

image

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

What?

It doesn't solve #2503 and why this background? It doesn't look good

image

My bad, I only checked in Guides page.

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak Now can you check, a prefix class was missing, now it only applies to that particular part.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu
image
Background changed there also.

But why are you changing background to fix #2503 ??

@nishu-murmu

nishu-murmu commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak applying z-index isn't causing anything.
Do you propose anything else?

I've added more specific header class for that.
Now it will only reflect in sidebar header.

Selection_009.bmp

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu There's no bug for me, at all, i don't know what are you're trying to fix guys.

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak The text is overlapping.
Selection_010.bmp

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu I can't see your .bmp files, let's attach it directly there in other format.

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author
Selection_001

@PatrykKuniczak I'm talking about the sidebar header, when you scroll the sidebar, those texts gets overlapped.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu Ok, now i see.

But still there's a problem:
image
(You can see it on smaller window)

There shouldn't be dark bg, it should be only on sidebar.

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak which page?, can you please provide entire page screenshot?

@PatrykKuniczak

PatrykKuniczak commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

@PatrykKuniczak which page?, can you please provide entire page screenshot?

https://deploy-preview-2504--creative-fairy-df92c4.netlify.app/guide/installation.html
image

@nishu-murmu

nishu-murmu commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak
Fixed the appropriate z-index.

I was looking completely else where for the fix 😅 .

@PatrykKuniczak PatrykKuniczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM 😄

@PatrykKuniczak
PatrykKuniczak merged commit eb93fa4 into main Jul 26, 2026
18 checks passed
@PatrykKuniczak
PatrykKuniczak deleted the fix/sidebar-overlay-issue branch July 26, 2026 08:37
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for helping make WXT better!

@PatrykKuniczak

PatrykKuniczak commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks for helping make WXT better!

@nishu-murmu If you won't have that messages in next PRs, you can add yourself there:

- name: Post Thank You Comment
if: >-
github.event.pull_request.user.login != 'aklinker1' &&
github.event.pull_request.user.login != 'Timeraa' &&
github.event.pull_request.user.login != 'PatrykKuniczak' &&
github.event.pull_request.user.login != 'dependabot[bot]' &&
github.event.pull_request.user.login != 'copilot-swe-agent[bot]'
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

@PatrykKuniczak cool, thanks for letting me know.

@aklinker1

Copy link
Copy Markdown
Member

This should be docs: not fix:, this doesn't fix a bug in a package's production code.

Also, this isn't a bug in vitepress by default, we introduced it in some custom style. That means the solution should have been to remove the style causing the issue, not add another one. At least, that was my initial thought, I didn't investigate and could be wrong.

Neither of these is a big deal, just an FYI for the future.

@nishu-murmu

Copy link
Copy Markdown
Collaborator Author

@aklinker1 Thanks for pointing it out! Will make sure of that next time.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@aklinker1 OOO yeah

This should be docs: not fix:, this doesn't fix a bug in a package's production code.

My fault, i've seen that in the start and i've plan to change it.
But i've missed it after a couple of reviews.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@aklinker1 If we'll change title now, on release this PR goes into "dosc" section, or it's basing on merge commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small CSS issue with z index when scrolling doc's sidebar

3 participants