Disable SSR for renderer pages#1279
Open
JackCC703 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderer/client-pagesrenderer/pagesas small Next route wrappers that load the real pages withssr: falseelectron-rendererwebpack target limited to client builds so server page collection can run in NodeWhy
Kap renders static Electron windows from Next output. Server-side evaluation of renderer modules forces the app to guard Electron-only APIs during build/page collection. Loading the renderer app shell and route bodies client-side avoids evaluating those Electron modules during SSR/static export.
Fixes #515.
Validation
npx -y -p node@16 -p yarn@1.22.22 yarn build-renderernpx -y -p node@16 -p yarn@1.22.22 yarn build-mainnpx -y -p node@16 -p yarn@1.22.22 yarn lintNote: lint completes with existing repository warnings around TODO comments and complexity; this PR does not add new lint errors.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: