Disable SSR for the renderer app shell#1278
Open
Noshkas wants to merge 2 commits into
Open
Conversation
c4c80a2 to
087a354
Compare
087a354 to
89081e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #515
Summary
_appinto a client-only app shell loaded withnext/dynamic({ssr: false})._app, so Next handles skipping server rendering directly.electron-rendererwebpack target to the client build only; the server/export build keeps the normal Node target and can evaluate dynamic imports without requiringwindow.Verification
npx -p node@16 -c 'node ./node_modules/.bin/xo'passed with existing warnings only.npx -p node@16 -c 'node ./node_modules/typescript/bin/tsc --noEmit -p tsconfig.json'npx tsc --noEmit -p renderer/tsconfig.jsonnpx -p node@16 -c 'node ./node_modules/next/dist/bin/next build renderer && node ./node_modules/next/dist/bin/next export renderer'renderer/out/editor.html, renders an empty#__nextshell rather than server-rendering the Electron UI.buildpassed on this PR after the CI image update.Note: I installed dependencies locally with
yarn install --frozen-lockfile --ignore-scripts --ignore-enginesbecause this older lockfile rejects modern Node during the engine check, then rannode node_modules/electron/install.jsso the renderer build could import Electron during page-data collection.