Show estimated GIF size in the editor#1277
Open
apples-kksk wants to merge 2 commits into
Open
Conversation
Author
|
The CircleCI build did not reach the project steps. CircleCI rejected the current macOS executor before checkout with:\n\n |
1a78019 to
ae8cefb
Compare
ae8cefb to
eb2eaff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small
GIF ~x MBestimate beside the export controls when GIF is selected.The estimate samples up to the first 2 seconds of the selected range through the existing GIF conversion/compression path, then scales that size to the selected duration. If the editor options change, the previous in-flight sample is canceled so stale estimates do not pile up.
Checked:
yarn build-main./node_modules/.bin/tsc --project renderer/tsconfig.json --noEmitnpx --yes -p node@16 -c 'yarn lint'(existing warnings only)\n-yarn test:main\n-npx --yes -p node@16 -c 'yarn build-renderer'\n\nCloses Show estimated GIF size in the editor window #172