Skip to content

fix: replace incorrect "role-based" label with "login-attempt-based" …#6129

Open
sandaluruba wants to merge 1 commit into
wso2:masterfrom
sandaluruba:master
Open

fix: replace incorrect "role-based" label with "login-attempt-based" …#6129
sandaluruba wants to merge 1 commit into
wso2:masterfrom
sandaluruba:master

Conversation

@sandaluruba
Copy link
Copy Markdown

@sandaluruba sandaluruba commented May 9, 2026

Purpose

Step 3 in the "Configure the login flow" section of the 'Add MFA based on login attempts' guide incorrectly said "role-based adaptive MFA" instead of "login-attempt-based adaptive MFA" due to a mistake from the role-based template.

Approach

Updated the two incorrect labels in login-attempt-based-template.md:

  • Step 3 heading: role-basedlogin-attempt-based
  • Step 3(b) description: role-based adaptive MFA scriptlogin-attempt-based adaptive MFA script

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The documentation guide for login-attempt-based adaptive MFA templates has been updated to clarify the correct configuration navigation path. The instructions now direct users to access the template through Predefined Flows → Conditional Login Flows → Adaptive MFA → Login-Attempts-Based → ADD.

Login-Attempt-Based Adaptive MFA Guide Update

Layer / File(s) Summary
Configuration Navigation Instructions
en/identity-server/next/docs/guides/authentication/conditional-auth/login-attempt-based-template.md
Instructions updated to specify navigation to Predefined Flows → Conditional Login Flows → Adaptive MFA → Login-Attempts-Based → ADD for configuring the login-attempt-based adaptive MFA template.

Suggested labels

Team/Authentication & registration

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description lacks required sections from the template including Test environment and Security checks. Add the missing required sections: Test environment (list JDK versions, OS, browsers tested), and Security checks (confirm no secrets committed, security standards followed).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing incorrect 'role-based' labels with 'login-attempt-based' in the login-attempt-based template guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants