NSSL-MP Bug/Error fixes#2348
Open
MicroTed wants to merge 1 commit into
Open
Conversation
Bug/Error fixes:
- 3-moment unit error and conversion corrections (drops->graupel and graupel->hail)
that could cause unrealistic large number concentrations of graupel and excessive
hail concentrations
- 3-moment consistency checks made more consistent with each other
- 3-moment rain breakup rate rewritten for reflectivity moment to prevent negative values
- Missing lookup table entry for new dry/wet growth (off by default: incwet=0)
Collaborator
|
After V4.8 is released, we should open a v4.8.1 release branch where this can be targeted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
module_mp_nssl_2mom.F:
KEYWORDS: 5 to 10 words related to commit, separated by commas
3-moment, hail conversion, rain freezing
SOURCE: Ted Mansell (NOAA/NSSL)
DESCRIPTION OF CHANGES:
Problem 1: For 3-moment option, the reflectivity moments were not having their units converted between advection (m^6/kg) and in-scheme (m^6/m^3), resulting in advection errors and incorrect output units
Solution 1: Add missing flags in init routine to convert units
Problem 2: Spurious number concentrations from two processes
Solution 1: Rewrite reflectivity check to be more robust
ISSUE: For use when this PR closes an issue.
Fixes #2344
LIST OF MODIFIED FILES:
module_mp_nssl_2mom.F
TESTS CONDUCTED:
Jenkins tests passed
RELEASE NOTE: NSSL Microphysics: Fixes a bug in the 3-moment option that caused advection errors; Fixes a reflectivity check in the drop freezing and hail conversion processes that caused too many graupel/hail particles to be produced (both 2/3-moment).