feat!: update Rector config style - #104
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughWalkthroughThe PR migrates Rector configuration to ChangesRector and PHPStan updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Rector
participant WorksomeRectorConfig
participant PHPStanConfig as PHPStan configuration
Rector->>WorksomeRectorConfig: Call configure()
WorksomeRectorConfig->>PHPStanConfig: Select available configuration
WorksomeRectorConfig-->>Rector: Return configured RectorConfigBuilder
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b143613 to
b0a1d07
Compare
b0a1d07 to
af4cb4d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/WorksomeRectorConfig.php`:
- Around line 25-33: Update WorksomeRectorConfig’s withPHPStanConfigs() setup to
include Larastan’s PHPStan extension configuration when the standard Larastan
bootstrap file exists, while preserving the existing project phpstan.neon
detection and bootstrap configuration. Use the corresponding Larastan extension
config path alongside the bootstrap path so Rector loads it explicitly.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9f7f9c79-997d-43f5-aab5-d72324257ac0
📒 Files selected for processing (8)
rector.phpsrc/PHPStan/Laravel/EnforceKebabCaseArtisanCommandsRule.phpsrc/PHPStan/Laravel/Migrations/RequireWithoutTimestampsRule.phpsrc/PHPStan/Laravel/Migrations/WithoutTimestampsVisitor.phpsrc/PHPStan/NamespaceBasedSuffixRule.phpsrc/WorksomeRectorConfig.phpstubs/ecs.php.stubstubs/rector.php.stub
💤 Files with no reviewable changes (1)
- src/PHPStan/Laravel/Migrations/RequireWithoutTimestampsRule.php
8766f2c to
baf9912
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This was meant to be introduced in 4.x, but will need a new major release as 5.x
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Refactor
Chores