Skip to content

fix added support for --force option when migrating the database #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsaiahPaget wants to merge 6 commits into
base: wip/1.3
Choose a base branch
from
+27 −2
Open

fix added support for --force option when migrating the database #1363

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d5ac48
fix added support for --force option when migration the database
Jun 8, 2025
b35f701
Update modules/system/console/WinterUp.php
LukeTowers Jun 10, 2025
3458dd7
Update modules/system/console/WinterUp.php
LukeTowers Jun 10, 2025
7dcb5ba
Update modules/system/console/WinterUp.php
LukeTowers Jun 10, 2025
fb27763
Merge branch 'develop' into fix/artisan-migrate-force
LukeTowers Jun 10, 2025
a5800d7
Adds support for additional configuration so that the need to use
Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions modules/system/console/WinterUp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<?php namespace System\Console;
<?php

namespace System\Console;

use Illuminate\Console\Command;
use Illuminate\Console\ConfirmableTrait;
use Illuminate\Contracts\Console\Isolatable;
use System\Classes\UpdateManager;

Expand All @@ -14,13 +17,17 @@
*/
class WinterUp extends Command implements Isolatable
{
use ConfirmableTrait;

/**
Comment thread
LukeTowers marked this conversation as resolved.
* The name and signature of the console command.
*
* @var string
*/
protected $signature = 'winter:up
{--seed : Included for compatibility with Laravel default signature, no effect at this time}';
{--seed : Included for compatibility with Laravel default signature, no effect at this time}
{--force : Force the operation to run when in production}
';

/**
* The console command description.
Expand All @@ -43,6 +50,10 @@ public function __construct()
*/
public function handle()
{
if (!$this->confirmToProceed()) {
Copy link
Copy Markdown
Member

@LukeTowers LukeTowers Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!$this->confirmToProceed()) {
if (config('database.migrations.confirm_in_prod', false) && !$this->confirmToProceed()) {

Copy link
Copy Markdown
Contributor Author

@IsaiahPaget IsaiahPaget Jun 15, 2025 •
edited by LukeTowers
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukeTowers Sorry I had a dyslexic moment reading your comment, I read 'comment' as 'commit' and I have never seen this 'suggested diff' feature so I am just now realizing this is just a suggestion, not actually added to the branch.

But now I am following lol. In the database.php did you have something like this in-mind:

    /*
    |--------------------------------------------------------------------------
    | Migration Repository Table
    |--------------------------------------------------------------------------
    |
    | This table keeps track of all the migrations that have already run for
    | your application. Using this information, we can determine which of
    | the migrations on disk haven't actually been run in the database.
    |
    */

    'migrations' = [
        'confirm_in_prod' => env('MIGRATION_CONFIRM_IN_PROD', false),
    ],

Copy link
Copy Markdown
Member

@LukeTowers LukeTowers Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much exactly that @IsaiahPaget

return 1;
}

$this->output->writeln('<info>Migrating application and plugins...</info>');

UpdateManager::instance()
Expand Down
Loading