Skip to content

✨ Implement xy_coords method on PyCudaCogReader struct - #82

Merged
weiji14 merged 3 commits into
mainfrom
py/xy_coords
Mar 24, 2026
Merged

✨ Implement xy_coords method on PyCudaCogReader struct#82
weiji14 merged 3 commits into
mainfrom
py/xy_coords

Conversation

@weiji14

@weiji14 weiji14 commented Mar 24, 2026

Copy link
Copy Markdown
Owner

Enable Python access the x- and y-coordinates derived from the affine transform.

Preview at https://cog3pio--82.org.readthedocs.build/en/82/api/#cog3pio.CudaCogReader.xy_coords

Cherry-picked from #71, continued from #70.

TODO:

  • Implement xy_coords method on PyCudaCogReader struct
  • Add unit tests

weiji14 added 2 commits March 24, 2026 20:24
Get list of x and y coordinates for the TIFF image from Python-side.

Cherry-picked from a683e31.
Test both CudaCogReader and CogReader's xy_coords methods' return numpy.ndarray outputs that are correct. Using a LINZ example DEM for the test case.
@weiji14 weiji14 added this to the 0.1.0 milestone Mar 24, 2026
@weiji14 weiji14 self-assigned this Mar 24, 2026
@weiji14 weiji14 added the enhancement New feature or request label Mar 24, 2026
@weiji14
weiji14 marked this pull request as ready for review March 24, 2026 08:01
@weiji14
weiji14 enabled auto-merge (squash) March 24, 2026 08:02
@weiji14
weiji14 disabled auto-merge March 24, 2026 08:05
Need to triple slash comment the docstring...
@codspeed-hq

codspeed-hq Bot commented Mar 24, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 90.23%

❌ 1 (👁 1) regressed benchmark
✅ 6 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
👁 test_read_geotiff_remote 19.1 ms 195.7 ms -90.23%

Comparing py/xy_coords (1e51abb) with main (0c688ff)

Open in CodSpeed

@weiji14
weiji14 enabled auto-merge (squash) March 24, 2026 08:26
@weiji14
weiji14 merged commit f6aa583 into main Mar 24, 2026
22 checks passed
@weiji14
weiji14 deleted the py/xy_coords branch March 24, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant