✨ Implement xy_coords method on PyCudaCogReader struct - #82
Merged
Conversation
Get list of x and y coordinates for the TIFF image from Python-side. Cherry-picked from a683e31.
Test both CudaCogReader and CogReader's xy_coords methods' return numpy.ndarray outputs that are correct. Using a LINZ example DEM for the test case.
This was referenced Mar 24, 2026
weiji14
marked this pull request as ready for review
March 24, 2026 08:01
weiji14
enabled auto-merge (squash)
March 24, 2026 08:02
weiji14
disabled auto-merge
March 24, 2026 08:05
Need to triple slash comment the docstring...
Merging this PR will degrade performance by 90.23%
Performance Changes
Comparing |
weiji14
enabled auto-merge (squash)
March 24, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Python access the x- and y-coordinates derived from the affine transform.
Preview at https://cog3pio--82.org.readthedocs.build/en/82/api/#cog3pio.CudaCogReader.xy_coords
Cherry-picked from #71, continued from #70.
TODO:
xy_coords methodonPyCudaCogReaderstruct