Fix/chained local scopes#64
Merged
Merged
Conversation
Model::__callStatic() applied a local scope directly on the raw Builder from newQuery() and returned it as-is. Chaining anything after that first scope (another scope, with(), etc.) hit a plain Query\Builder that has no idea what a scope is.
__call() forwarded every unknown method straight to the raw Builder, including scope names. A second scope in a chain — e.g. Model::active()->adult() — failed with "Call to undefined method Query\Builder::adult()". Now it checks for a matching scopeXxx() on the model first.
Adds scopeAdult() to the TestUser fixture and two regression tests: scope->scope->get() and scope->where()->orderBy()->get(). Both reproduce the original bug before the fix and pass after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.